]> git.ipfire.org Git - thirdparty/squid.git/commitdiff
Docs: document ConnOpener::swanSong() better
authorAmos Jeffries <squid3@treenet.co.nz>
Fri, 1 Mar 2013 11:05:57 +0000 (04:05 -0700)
committerAmos Jeffries <squid3@treenet.co.nz>
Fri, 1 Mar 2013 11:05:57 +0000 (04:05 -0700)
src/comm/ConnOpener.cc

index 7f19c50b000b6167917a8c4d55e1019626e562ae..078a0cc1ed5d8569ebd5cd5d0c932b6b9efef8ec 100644 (file)
@@ -57,9 +57,11 @@ Comm::ConnOpener::swanSong()
         sendAnswer(COMM_ERR_CONNECT, 0, "Comm::ConnOpener::swanSong");
     }
 
+    // did we abort with a temporary FD assigned?
     if (temporaryFd_ >= 0)
         closeFd();
 
+    // did we abort while waiting between retries?
     if (calls_.sleep_)
         cancelSleep();
 
@@ -110,6 +112,7 @@ Comm::ConnOpener::sendAnswer(comm_err_t errFlag, int xerrno, const char *why)
         if (callback_->canceled()) {
             debugs(5, 4, conn_ << " not calling canceled " << *callback_ <<
                    " [" << callback_->id << ']' );
+            // TODO save the pconn to the pconnPool ?
         } else {
             typedef CommConnectCbParams Params;
             Params &params = GetCommParams<Params>(callback_);