]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
Fortran: Free type-bound procedure structs
authorBernhard Reutner-Fischer <aldot@gcc.gnu.org>
Wed, 6 Dec 2017 21:55:10 +0000 (22:55 +0100)
committerBernhard Reutner-Fischer <aldot@gcc.gnu.org>
Fri, 29 Oct 2021 16:26:27 +0000 (18:26 +0200)
compiling gfortran.dg/typebound_proc_31.f90 leaked the type-bound
structs:

56 bytes in 1 blocks are definitely lost.
  at 0x4C2CC05: calloc (vg_replace_malloc.c:711)
  by 0x151EA90: xcalloc (xmalloc.c:162)
  by 0x8E3E4F: gfc_get_typebound_proc(gfc_typebound_proc*) (symbol.c:4945)
  by 0x84C095: match_procedure_in_type (decl.c:10486)
  by 0x84C095: gfc_match_procedure() (decl.c:6696)
...

gcc/fortran/ChangeLog:

2017-12-06  Bernhard Reutner-Fischer  <aldot@gcc.gnu.org>

* symbol.c (free_tb_tree): Free type-bound procedure struct.
(gfc_get_typebound_proc): Use explicit memcpy for clarity.

gcc/fortran/symbol.c

index c77f3f849625b52fa9ceb68007098a946c318320..34c0ba2fac4083eece8a2e230c482ebd3364d861 100644 (file)
@@ -3832,7 +3832,7 @@ free_tb_tree (gfc_symtree *t)
 
   /* TODO: Free type-bound procedure structs themselves; probably needs some
      sort of ref-counting mechanism.  */
-
+  free (t->n.tb);
   free (t);
 }
 
@@ -5073,7 +5073,7 @@ gfc_get_typebound_proc (gfc_typebound_proc *tb0)
 
   result = XCNEW (gfc_typebound_proc);
   if (tb0)
-    *result = *tb0;
+    memcpy (result, tb0, sizeof (gfc_typebound_proc));
   result->error = 1;
 
   latest_undo_chgset->tbps.safe_push (result);