[#2604] Corrected compiler warnings

src/lib/dhcpsrv/mysql_lease_mgr.cc
src/lib/dhcpsrv/pgsql_lease_mgr.cc
src/lib/dhcpsrv/tests/lease_mgr_unittest.cc
    Commented out unused parameters

src/lib/dhcpsrv/mysql_lease_mgr.h
src/lib/dhcpsrv/pgsql_lease_mgr.h
    added missing setExtendedInfoTablesEnabled() variant

diff --git a/src/lib/dhcpsrv/mysql_lease_mgr.cc b/src/lib/dhcpsrv/mysql_lease_mgr.cc
index 791e52a4af3f80269fceb350f7bfe09ca50095fd..43be8a948d389cbd8963b5083efe9e82fc18be0c 100644 (file)
--- a/src/lib/dhcpsrv/mysql_lease_mgr.cc
+++ b/src/lib/dhcpsrv/mysql_lease_mgr.cc
@@ -3373,14 +3373,14 @@ MySqlLeaseMgr::deleteExtendedInfo6(const IOAddress& /* addr */) {
 void
 MySqlLeaseMgr::addRelayId6(const IOAddress& /* lease_addr */,
                            const IOAddress& /* link_addr */,
-                           const vector<uint8_t>& relay_id) {
+                           const vector<uint8_t>& /* relay_id */) {
     isc_throw(NotImplemented, "MySqlLeaseMgr::addRelayId6 not implemented");
 }
 
 void
 MySqlLeaseMgr::addRemoteId6(const IOAddress& /* lease_addr */,
                             const IOAddress& /* link_addr */,
-                            const vector<uint8_t>& remote_id) {
+                            const vector<uint8_t>& /* remote_id */) {
     isc_throw(NotImplemented, "MySqlLeaseMgr::addRemoteId6 not implemented");
 }
 

diff --git a/src/lib/dhcpsrv/mysql_lease_mgr.h b/src/lib/dhcpsrv/mysql_lease_mgr.h
index 786d63567a9e1f02e2d15094541437c1cad4eeb1..876a3b68d05d3cae69bceb70cc218890698b7536 100644 (file)
--- a/src/lib/dhcpsrv/mysql_lease_mgr.h
+++ b/src/lib/dhcpsrv/mysql_lease_mgr.h
@@ -1145,6 +1145,17 @@ protected:
         }
     }
 
+    /// @brief Decode parameters to set whether the lease extended info tables
+    /// are enabled.
+    ///
+    /// @note: common code in constructors.
+    ///
+    /// @param parameters The parameter map.
+    virtual void setExtendedInfoTablesEnabled(const db::DatabaseConnection::ParameterMap& /* parameters */) override {
+        isc_throw(isc::NotImplemented,
+                  "extended info tables are not yet supported by mysql");
+    }
+
     /// @brief Delete lease6 extended info from tables.
     ///
     /// @param addr The address of the lease.

diff --git a/src/lib/dhcpsrv/pgsql_lease_mgr.cc b/src/lib/dhcpsrv/pgsql_lease_mgr.cc
index 4149cd7f21935cbbf6e5c0a350152d8f3d04d68f..db9f9cb569592ca90d660bba0a1275b2ab3fabcc 100644 (file)
--- a/src/lib/dhcpsrv/pgsql_lease_mgr.cc
+++ b/src/lib/dhcpsrv/pgsql_lease_mgr.cc
@@ -2567,14 +2567,14 @@ PgSqlLeaseMgr::deleteExtendedInfo6(const IOAddress& /* addr */) {
 void
 PgSqlLeaseMgr::addRelayId6(const IOAddress& /* lease_addr */,
                            const IOAddress& /* link_addr */,
-                           const vector<uint8_t>& relay_id) {
+                           const vector<uint8_t>& /* relay_id */) {
     isc_throw(NotImplemented, "PgSqlLeaseMgr::addRelayId6 not implemented");
 }
 
 void
 PgSqlLeaseMgr::addRemoteId6(const IOAddress& /* lease_addr */,
                             const IOAddress& /* link_addr */,
-                            const vector<uint8_t>& remote_id) {
+                            const vector<uint8_t>& /* remote_id */) {
     isc_throw(NotImplemented, "PgSqlLeaseMgr::addRemoteId6 not implemented");
 }
 

diff --git a/src/lib/dhcpsrv/pgsql_lease_mgr.h b/src/lib/dhcpsrv/pgsql_lease_mgr.h
index f7bb7e64b922684ff35bca27222d1f9bfe608883..f2b3beaa3bc685553506e1d95d865276a22b9084 100644 (file)
--- a/src/lib/dhcpsrv/pgsql_lease_mgr.h
+++ b/src/lib/dhcpsrv/pgsql_lease_mgr.h
@@ -1104,6 +1104,21 @@ protected:
         }
     }
 
+    /// @brief Decode parameters to set whether the lease extended info tables
+    /// are enabled.
+    ///
+    /// @note: common code in constructors.
+    ///
+    /// @param parameters The parameter map.
+    virtual void setExtendedInfoTablesEnabled(const db::DatabaseConnection::ParameterMap& /* parameters */) override {
+        isc_throw(isc::NotImplemented,
+                  "extended info tables are not yet supported by mysql");
+    }
+
+     /// @brief Delete lease6 extended info from tables.
+     ///
+     /// @param addr The address of the lease.
+
     /// @brief Delete lease6 extended info from tables.
     ///
     /// @param addr The address of the lease.

diff --git a/src/lib/dhcpsrv/tests/lease_mgr_unittest.cc b/src/lib/dhcpsrv/tests/lease_mgr_unittest.cc
index 8549252c3028153e0d7bbd630ff44ed90a22e20f..cb187cb53c2504e4bec6b73686831c5f02a09676 100644 (file)
--- a/src/lib/dhcpsrv/tests/lease_mgr_unittest.cc
+++ b/src/lib/dhcpsrv/tests/lease_mgr_unittest.cc
@@ -407,7 +407,7 @@ public:
     void
     addRelayId6(const IOAddress& /* lease_addr */,
                 const IOAddress& /* link_addr */,
-                const vector<uint8_t>& relay_id) override {
+                const vector<uint8_t>& /* relay_id */) override {
         isc_throw(NotImplemented, "ConcreteLeaseMgr::addRelayId6 not implemented");
     }
 
@@ -415,7 +415,7 @@ public:
     void
     addRemoteId6(const IOAddress& /* lease_addr */,
                  const IOAddress& /* link_addr */,
-                 const vector<uint8_t>& remote_id) override {
+                 const vector<uint8_t>& /* remote_id */) override {
         isc_throw(NotImplemented, "ConcreteLeaseMgr::addRemoteId6 not implemented");
     }