Neighbor locking: forgotten neighbors to unlink are actually a bug.

These may cause runaway pointers.

diff --git a/nest/iface.c b/nest/iface.c
index 3d1483ace3ad21f59722eba760e79fd01e66ac4f..897948acccb182f5c44d35c2c0fab0d5c5e0d362 100644 (file)
--- a/nest/iface.c
+++ b/nest/iface.c
@@ -684,7 +684,7 @@ iface_unsubscribe(struct iface_subscription *s)
 
   WALK_TLIST_DELSAFE(proto_neigh, n, &p->neighbors)
   {
-    log(L_WARN "%s: Unlinking forgotten neighbor %I", p->name, n->addr);
+    bug("%s: Unlinking forgotten neighbor %I", p->name, n->addr);
     neigh_unlink_locked(n);
   }