]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: amplifiers: ada4250: used dev local variable
authorDavid Lechner <dlechner@baylibre.com>
Wed, 11 Jun 2025 21:33:01 +0000 (16:33 -0500)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Thu, 26 Jun 2025 18:32:54 +0000 (19:32 +0100)
Replace local spi variable with dev in ada4250_init() since spi is not
used directly.

Signed-off-by: David Lechner <dlechner@baylibre.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-1-bf85ddea79f2@baylibre.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/amplifiers/ada4250.c

index f81438460aa51ce30f8f605c60ee5be5c8c251d3..397c1e1545cfccad9b0ff58b133796d415130064 100644 (file)
@@ -299,24 +299,24 @@ static void ada4250_reg_disable(void *data)
 
 static int ada4250_init(struct ada4250_state *st)
 {
+       struct device *dev = &st->spi->dev;
        int ret;
        u16 chip_id;
-       struct spi_device *spi = st->spi;
 
-       st->refbuf_en = device_property_read_bool(&spi->dev, "adi,refbuf-enable");
+       st->refbuf_en = device_property_read_bool(dev, "adi,refbuf-enable");
 
-       st->reg = devm_regulator_get(&spi->dev, "avdd");
+       st->reg = devm_regulator_get(dev, "avdd");
        if (IS_ERR(st->reg))
-               return dev_err_probe(&spi->dev, PTR_ERR(st->reg),
+               return dev_err_probe(dev, PTR_ERR(st->reg),
                                     "failed to get the AVDD voltage\n");
 
        ret = regulator_enable(st->reg);
        if (ret) {
-               dev_err(&spi->dev, "Failed to enable specified AVDD supply\n");
+               dev_err(dev, "Failed to enable specified AVDD supply\n");
                return ret;
        }
 
-       ret = devm_add_action_or_reset(&spi->dev, ada4250_reg_disable, st->reg);
+       ret = devm_add_action_or_reset(dev, ada4250_reg_disable, st->reg);
        if (ret)
                return ret;
 
@@ -333,7 +333,7 @@ static int ada4250_init(struct ada4250_state *st)
        chip_id = le16_to_cpu(st->reg_val_16);
 
        if (chip_id != ADA4250_CHIP_ID) {
-               dev_err(&spi->dev, "Invalid chip ID.\n");
+               dev_err(dev, "Invalid chip ID.\n");
                return -EINVAL;
        }