]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iommu/vt-d: Fix 64-bit accesses to 32-bit DMAR_GSTS_REG
authorCQ Tang <cq.tang@intel.com>
Wed, 13 Jan 2016 21:15:03 +0000 (21:15 +0000)
committerSasha Levin <sasha.levin@oracle.com>
Tue, 23 Feb 2016 05:46:35 +0000 (00:46 -0500)
[ Upstream commit fda3bec12d0979aae3f02ee645913d66fbc8a26e ]

This is a 32-bit register. Apparently harmless on real hardware, but
causing justified warnings in simulation.

Signed-off-by: CQ Tang <cq.tang@intel.com>
Signed-off-by: David Woodhouse <David.Woodhouse@intel.com>
Cc: stable@vger.kernel.org
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
drivers/iommu/dmar.c
drivers/iommu/intel_irq_remapping.c

index 9847613085e157976707e0d1aa0cc87c3e8b3c68..5a2ec39e1fd9befadf28471d13110e88f98bc01a 100644 (file)
@@ -1342,7 +1342,7 @@ void dmar_disable_qi(struct intel_iommu *iommu)
 
        raw_spin_lock_irqsave(&iommu->register_lock, flags);
 
-       sts =  dmar_readq(iommu->reg + DMAR_GSTS_REG);
+       sts =  readl(iommu->reg + DMAR_GSTS_REG);
        if (!(sts & DMA_GSTS_QIES))
                goto end;
 
index 5709ae9c3e771d2f82a1bda2a23d500d8f4faffe..04b39be8f1f36b406f186536b5b8353946bbf975 100644 (file)
@@ -544,7 +544,7 @@ static void iommu_disable_irq_remapping(struct intel_iommu *iommu)
 
        raw_spin_lock_irqsave(&iommu->register_lock, flags);
 
-       sts = dmar_readq(iommu->reg + DMAR_GSTS_REG);
+       sts = readl(iommu->reg + DMAR_GSTS_REG);
        if (!(sts & DMA_GSTS_IRES))
                goto end;