]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu: caps: Don't leak package name string in virQEMUCapsInitQMPMonitor
authorPeter Krempa <pkrempa@redhat.com>
Fri, 29 Mar 2019 08:32:14 +0000 (09:32 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Wed, 3 Apr 2019 09:58:09 +0000 (11:58 +0200)
If the detected qemu version is below our required version 'package'
would be leaked.

Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Erik Skultety <eskultet@redhat.com>
src/qemu/qemu_capabilities.c

index 4c52dfc714e3b9bfff273b961e0c6ad911934b7d..e3db7ce71c94a3d38bf632ae0d8bc637d35b9bc9 100644 (file)
@@ -4322,7 +4322,7 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
 {
     int ret = -1;
     int major, minor, micro;
-    char *package = NULL;
+    VIR_AUTOFREE(char *) package = NULL;
 
     /* @mon is supposed to be locked by callee */
 
@@ -4347,7 +4347,7 @@ virQEMUCapsInitQMPMonitor(virQEMUCapsPtr qemuCaps,
     }
 
     qemuCaps->version = major * 1000000 + minor * 1000 + micro;
-    qemuCaps->package = package;
+    VIR_STEAL_PTR(qemuCaps->package, package);
     qemuCaps->usedQMP = true;
 
     if (virQEMUCapsInitQMPArch(qemuCaps, mon) < 0)