]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
virQEMUCapsLoadCache: Parse <selfvers/> properly
authorMichal Privoznik <mprivozn@redhat.com>
Tue, 3 Jan 2023 16:54:57 +0000 (17:54 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 4 Jan 2023 15:21:58 +0000 (16:21 +0100)
In a recent commit, when ditching virXPathULong() the parsing of
<selfvers/> was changed. But it was changed to virXMLPropUInt()
which is not correct because the value we're interested in is not
in an attribute but element itself.

Fixes: a3c7426839df25f4026707c5877be75f2461f5e9
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Jiri Denemark <jdenemar@redhat.com>
src/qemu/qemu_capabilities.c

index e6024a2d758e64adf001e818ae08cdeca620878c..0c16366f217d30a906880be5a953e52466a7dbc2 100644 (file)
@@ -4533,8 +4533,8 @@ virQEMUCapsLoadCache(virArch hostArch,
     }
     qemuCaps->libvirtCtime = (time_t)l;
 
-    if (virXMLPropUInt(ctxt->node, "selfvers", 10, VIR_XML_PROP_NONE,
-                       &qemuCaps->libvirtVersion) < 0)
+    if (virXPathUInt("string(./selfvers)", ctxt,
+                     &qemuCaps->libvirtVersion) < 0)
         return -1;
 
     if (!skipInvalidation &&