]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm/mglru: rename variables related to aging and rotation
authorKairui Song <kasong@tencent.com>
Mon, 27 Apr 2026 18:06:53 +0000 (02:06 +0800)
committerAndrew Morton <akpm@linux-foundation.org>
Thu, 4 Jun 2026 21:45:03 +0000 (14:45 -0700)
The current variable name isn't helpful.  Make the variable names more
meaningful.

Only naming change, no behavior change.

Link: https://lore.kernel.org/20260428-mglru-reclaim-v7-2-02fabb92dc43@tencent.com
Signed-off-by: Kairui Song <kasong@tencent.com>
Suggested-by: Barry Song <baohua@kernel.org>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
Reviewed-by: Chen Ridong <chenridong@huaweicloud.com>
Reviewed-by: Barry Song <baohua@kernel.org>
Reviewed-by: Axel Rasmussen <axelrasmussen@google.com>
Acked-by: Shakeel Butt <shakeel.butt@linux.dev>
Cc: Chris Li <chrisl@kernel.org>
Cc: David Hildenbrand <david@kernel.org>
Cc: David Stevens <stevensd@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Kalesh Singh <kaleshsingh@google.com>
Cc: Leno Hou <lenohou@gmail.com>
Cc: Lorenzo Stoakes <ljs@kernel.org>
Cc: Michal Hocko <mhocko@kernel.org>
Cc: Suren Baghdasaryan <surenb@google.com>
Cc: Vernon Yang <vernon2gm@gmail.com>
Cc: Wei Xu <weixugc@google.com>
Cc: Yafang <laoar.shao@gmail.com>
Cc: Yuanchu Xie <yuanchu@google.com>
Cc: Yu Zhao <yuzhao@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/vmscan.c

index 5901219dd7fc1af7eb16577d4859e3739390c456..9c47a4aa825aa512397d5c066f41e8d1e54ec8bc 100644 (file)
@@ -4938,7 +4938,7 @@ static bool should_run_aging(struct lruvec *lruvec, unsigned long max_seq,
  */
 static long get_nr_to_scan(struct lruvec *lruvec, struct scan_control *sc, int swappiness)
 {
-       bool success;
+       bool need_aging;
        unsigned long nr_to_scan;
        struct mem_cgroup *memcg = lruvec_memcg(lruvec);
        DEFINE_MAX_SEQ(lruvec);
@@ -4946,7 +4946,7 @@ static long get_nr_to_scan(struct lruvec *lruvec, struct scan_control *sc, int s
        if (mem_cgroup_below_min(sc->target_mem_cgroup, memcg))
                return -1;
 
-       success = should_run_aging(lruvec, max_seq, swappiness, &nr_to_scan);
+       need_aging = should_run_aging(lruvec, max_seq, swappiness, &nr_to_scan);
 
        /* try to scrape all its memory if this memcg was deleted */
        if (nr_to_scan && !mem_cgroup_online(memcg))
@@ -4955,7 +4955,7 @@ static long get_nr_to_scan(struct lruvec *lruvec, struct scan_control *sc, int s
        nr_to_scan = apply_proportional_protection(memcg, sc, nr_to_scan);
 
        /* try to get away with not aging at the default priority */
-       if (!success || sc->priority == DEF_PRIORITY)
+       if (!need_aging || sc->priority == DEF_PRIORITY)
                return nr_to_scan >> sc->priority;
 
        /* stop scanning this lruvec as it's low on cold folios */
@@ -5044,7 +5044,7 @@ static bool try_to_shrink_lruvec(struct lruvec *lruvec, struct scan_control *sc)
 
 static int shrink_one(struct lruvec *lruvec, struct scan_control *sc)
 {
-       bool success;
+       bool need_rotate;
        unsigned long scanned = sc->nr_scanned;
        unsigned long reclaimed = sc->nr_reclaimed;
        struct mem_cgroup *memcg = lruvec_memcg(lruvec);
@@ -5062,7 +5062,7 @@ static int shrink_one(struct lruvec *lruvec, struct scan_control *sc)
                memcg_memory_event(memcg, MEMCG_LOW);
        }
 
-       success = try_to_shrink_lruvec(lruvec, sc);
+       need_rotate = try_to_shrink_lruvec(lruvec, sc);
 
        shrink_slab(sc->gfp_mask, pgdat->node_id, memcg, sc->priority);
 
@@ -5072,10 +5072,10 @@ static int shrink_one(struct lruvec *lruvec, struct scan_control *sc)
 
        flush_reclaim_state(sc);
 
-       if (success && mem_cgroup_online(memcg))
+       if (need_rotate && mem_cgroup_online(memcg))
                return MEMCG_LRU_YOUNG;
 
-       if (!success && lruvec_is_sizable(lruvec, sc))
+       if (!need_rotate && lruvec_is_sizable(lruvec, sc))
                return 0;
 
        /* one retry if offlined or too small */