]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
samples/damon: change enable parameters to enabled
authorHonggyu Kim <honggyu.kim@sk.com>
Mon, 7 Jul 2025 02:45:47 +0000 (11:45 +0900)
committerAndrew Morton <akpm@linux-foundation.org>
Sun, 20 Jul 2025 01:59:47 +0000 (18:59 -0700)
The damon_{lru_sort,reclaim,stat} kernel modules use "enabled" parameter
knobs as follows.

  /sys/module/damon_lru_sort/parameters/enabled
  /sys/module/damon_reclaim/parameters/enabled
  /sys/module/damon_stat/parameters/enabled

However, other sample modules of damon use "enable" parameter knobs so
it'd be better to rename them from "enable" to "enabled" to keep the
consistency with other damon modules.

Before:
  /sys/module/damon_sample_wsse/parameters/enable
  /sys/module/damon_sample_prcl/parameters/enable
  /sys/module/damon_sample_mtier/parameters/enable

After:
  /sys/module/damon_sample_wsse/parameters/enabled
  /sys/module/damon_sample_prcl/parameters/enabled
  /sys/module/damon_sample_mtier/parameters/enabled

There is no functional changes in this patch.

Link: https://lkml.kernel.org/r/20250707024548.1964-1-honggyu.kim@sk.com
Signed-off-by: Honggyu Kim <honggyu.kim@sk.com>
Reviewed-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
samples/damon/mtier.c
samples/damon/prcl.c
samples/damon/wsse.c

index 537bc6eae9f7938145a252646df1ee86bce3c999..42e14df16f44afe1e45098655a3166b077f1bca5 100644 (file)
@@ -38,14 +38,14 @@ module_param(node0_mem_free_bp, ulong, 0600);
 static int damon_sample_mtier_enable_store(
                const char *val, const struct kernel_param *kp);
 
-static const struct kernel_param_ops enable_param_ops = {
+static const struct kernel_param_ops enabled_param_ops = {
        .set = damon_sample_mtier_enable_store,
        .get = param_get_bool,
 };
 
-static bool enable __read_mostly;
-module_param_cb(enable, &enable_param_ops, &enable, 0600);
-MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_MTIER");
+static bool enabled __read_mostly;
+module_param_cb(enabled, &enabled_param_ops, &enabled, 0600);
+MODULE_PARM_DESC(enabled, "Enable or disable DAMON_SAMPLE_MTIER");
 
 static struct damon_ctx *ctxs[2];
 
@@ -167,20 +167,20 @@ static bool init_called;
 static int damon_sample_mtier_enable_store(
                const char *val, const struct kernel_param *kp)
 {
-       bool enabled = enable;
+       bool is_enabled = enabled;
        int err;
 
-       err = kstrtobool(val, &enable);
+       err = kstrtobool(val, &enabled);
        if (err)
                return err;
 
-       if (enable == enabled)
+       if (enabled == is_enabled)
                return 0;
 
-       if (enable) {
+       if (enabled) {
                err = damon_sample_mtier_start();
                if (err)
-                       enable = false;
+                       enabled = false;
                return err;
        }
        damon_sample_mtier_stop();
@@ -192,10 +192,10 @@ static int __init damon_sample_mtier_init(void)
        int err = 0;
 
        init_called = true;
-       if (enable) {
+       if (enabled) {
                err = damon_sample_mtier_start();
                if (err)
-                       enable = false;
+                       enabled = false;
        }
        return 0;
 }
index 4b0e47718c62c42034b6565e982409d9bb67b8bd..8a312dba7691c6e0ff6b6c9707bbef7174a7677a 100644 (file)
@@ -22,14 +22,14 @@ module_param(target_pid, int, 0600);
 static int damon_sample_prcl_enable_store(
                const char *val, const struct kernel_param *kp);
 
-static const struct kernel_param_ops enable_param_ops = {
+static const struct kernel_param_ops enabled_param_ops = {
        .set = damon_sample_prcl_enable_store,
        .get = param_get_bool,
 };
 
-static bool enable __read_mostly;
-module_param_cb(enable, &enable_param_ops, &enable, 0600);
-MODULE_PARM_DESC(enable, "Enable of disable DAMON_SAMPLE_WSSE");
+static bool enabled __read_mostly;
+module_param_cb(enabled, &enabled_param_ops, &enabled, 0600);
+MODULE_PARM_DESC(enabled, "Enable or disable DAMON_SAMPLE_PRCL");
 
 static struct damon_ctx *ctx;
 static struct pid *target_pidp;
@@ -119,20 +119,20 @@ static bool init_called;
 static int damon_sample_prcl_enable_store(
                const char *val, const struct kernel_param *kp)
 {
-       bool enabled = enable;
+       bool is_enabled = enabled;
        int err;
 
-       err = kstrtobool(val, &enable);
+       err = kstrtobool(val, &enabled);
        if (err)
                return err;
 
-       if (enable == enabled)
+       if (enabled == is_enabled)
                return 0;
 
-       if (enable) {
+       if (enabled) {
                err = damon_sample_prcl_start();
                if (err)
-                       enable = false;
+                       enabled = false;
                return err;
        }
        damon_sample_prcl_stop();
@@ -144,10 +144,10 @@ static int __init damon_sample_prcl_init(void)
        int err = 0;
 
        init_called = true;
-       if (enable) {
+       if (enabled) {
                err = damon_sample_prcl_start();
                if (err)
-                       enable = false;
+                       enabled = false;
        }
        return 0;
 }
index 89fc76f31d5ec5dd6211917b922a9c6bc90dca67..d87b3b0801d2c4b5236d4128786ab3a60b1f45d0 100644 (file)
@@ -23,14 +23,14 @@ module_param(target_pid, int, 0600);
 static int damon_sample_wsse_enable_store(
                const char *val, const struct kernel_param *kp);
 
-static const struct kernel_param_ops enable_param_ops = {
+static const struct kernel_param_ops enabled_param_ops = {
        .set = damon_sample_wsse_enable_store,
        .get = param_get_bool,
 };
 
-static bool enable __read_mostly;
-module_param_cb(enable, &enable_param_ops, &enable, 0600);
-MODULE_PARM_DESC(enable, "Enable or disable DAMON_SAMPLE_WSSE");
+static bool enabled __read_mostly;
+module_param_cb(enabled, &enabled_param_ops, &enabled, 0600);
+MODULE_PARM_DESC(enabled, "Enable or disable DAMON_SAMPLE_WSSE");
 
 static struct damon_ctx *ctx;
 static struct pid *target_pidp;
@@ -99,20 +99,20 @@ static bool init_called;
 static int damon_sample_wsse_enable_store(
                const char *val, const struct kernel_param *kp)
 {
-       bool enabled = enable;
+       bool is_enabled = enabled;
        int err;
 
-       err = kstrtobool(val, &enable);
+       err = kstrtobool(val, &enabled);
        if (err)
                return err;
 
-       if (enable == enabled)
+       if (enabled == is_enabled)
                return 0;
 
-       if (enable) {
+       if (enabled) {
                err = damon_sample_wsse_start();
                if (err)
-                       enable = false;
+                       enabled = false;
                return err;
        }
        damon_sample_wsse_stop();
@@ -124,10 +124,10 @@ static int __init damon_sample_wsse_init(void)
        int err = 0;
 
        init_called = true;
-       if (enable) {
+       if (enabled) {
                err = damon_sample_wsse_start();
                if (err)
-                       enable = false;
+                       enabled = false;
        }
        return err;
 }