]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
udevProcessCCW: Initialize variable
authorTim Wiederhake <twiederh@redhat.com>
Mon, 1 Feb 2021 12:42:03 +0000 (13:42 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 2 Feb 2021 14:00:55 +0000 (15:00 +0100)
`udevGetIntSysfsAttr` does not necessarily write to the third parameter,
even when it returns 0.

This was found by clang-tidy's
"clang-analyzer-core.UndefinedBinaryOperatorResult" check.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
src/node_device/node_device_udev.c

index fceb135aa5bb4e6201a9d78bff6085e5ebf42050..09048fb23f481029eb0219f3fcdb86474526f756 100644 (file)
@@ -1100,7 +1100,7 @@ static int
 udevProcessCCW(struct udev_device *device,
                virNodeDeviceDefPtr def)
 {
-    int online;
+    int online = 0;
 
     /* process only online devices to keep the list sane */
     if (udevGetIntSysfsAttr(device, "online", &online, 0) < 0 || online != 1)