]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
selftests: net: py: capitalize defer queue and improve import
authorJakub Kicinski <kuba@kernel.org>
Thu, 8 Jan 2026 22:52:56 +0000 (14:52 -0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 10 Jan 2026 23:11:59 +0000 (15:11 -0800)
Import utils and refer to the global defer queue that way instead
of importing the queue. This will make it possible to assign value
to the global variable. While at it capitalize the name, to comply
with the Python coding style.

Reviewed-by: Petr Machata <petrm@nvidia.com>
Link: https://patch.msgid.link/20260108225257.2684238-1-kuba@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/lib/py/ksft.py
tools/testing/selftests/net/lib/py/utils.py

index 531e7fa1b3ea1e73185267e27d3e10043c17898f..248cd1a723a3b81de5ef65bd46320c8ee45cd425 100644 (file)
@@ -8,7 +8,7 @@ import time
 import traceback
 from collections import namedtuple
 from .consts import KSFT_MAIN_NAME
-from .utils import global_defer_queue
+from . import utils
 
 KSFT_RESULT = None
 KSFT_RESULT_ALL = True
@@ -157,10 +157,10 @@ def ksft_flush_defer():
     global KSFT_RESULT
 
     i = 0
-    qlen_start = len(global_defer_queue)
-    while global_defer_queue:
+    qlen_start = len(utils.GLOBAL_DEFER_QUEUE)
+    while utils.GLOBAL_DEFER_QUEUE:
         i += 1
-        entry = global_defer_queue.pop()
+        entry = utils.GLOBAL_DEFER_QUEUE.pop()
         try:
             entry.exec_only()
         except Exception:
index 106ee1f2df86a817810328f8eb12511330c5db55..2dde34560d653b1f99b2ee2e1fbf6e503f4c3ccb 100644 (file)
@@ -141,7 +141,7 @@ class bkg(cmd):
         return self.process(terminate=terminate, fail=self.check_fail)
 
 
-global_defer_queue = []
+GLOBAL_DEFER_QUEUE = []
 
 
 class defer:
@@ -153,7 +153,7 @@ class defer:
         self.args = args
         self.kwargs = kwargs
 
-        self._queue =  global_defer_queue
+        self._queue = GLOBAL_DEFER_QUEUE
         self._queue.append(self)
 
     def __enter__(self):