Bug 343189: checksetup.pl HASH reference error with 2.18.5 to 2.20.2/2.22 upgrade

Patch By Max Kanat-Alexander <mkanat@bugzilla.org> r=bkor, a=justdave

diff --git a/checksetup.pl b/checksetup.pl
index 3484bec970656ee1d57a9702fca51346af2a01f0..7794e2123f0398ff9f35e60357b86ed0056930df 100755 (executable)
--- a/checksetup.pl
+++ b/checksetup.pl
@@ -2231,7 +2231,8 @@ if (!$dbh->bz_column_info('bugs', 'lastdiffed')) {
 # declared to be unique.  Sure enough, somehow, I got 22 duplicated entries
 # in my database.  This code detects that, cleans up the duplicates, and
 # then tweaks the table to declare the field to be unique.  What a pain.
-if (!$dbh->bz_index_info('profiles', 'profiles_login_name_idx')->{TYPE}) {
+if (!$dbh->bz_index_info('profiles', 'profiles_login_name_idx') ||
+    !$dbh->bz_index_info('profiles', 'profiles_login_name_idx')->{TYPE}) {
     print "Searching for duplicate entries in the profiles table ...\n";
     while (1) {
         # This code is weird in that it loops around and keeps doing this