]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
gfs2: remove redundant warnings
authorAndreas Gruenbacher <agruenba@redhat.com>
Mon, 3 Mar 2025 11:00:14 +0000 (12:00 +0100)
committerAndreas Gruenbacher <agruenba@redhat.com>
Mon, 10 Mar 2025 17:15:38 +0000 (18:15 +0100)
In glock_set_object() and glock_clear_object(), there is no need to
print the glock type and number when we dump the entire glock, anyway.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
fs/gfs2/glock.c

index 3c26812b12a8d1592479a1c5cec3a8a6923ef8ff..443d25c80571228836b9406d6e1663e8a1c368f1 100644 (file)
@@ -910,12 +910,8 @@ void glock_set_object(struct gfs2_glock *gl, void *object)
        prev_object = gl->gl_object;
        gl->gl_object = object;
        spin_unlock(&gl->gl_lockref.lock);
-       if (gfs2_assert_warn(gl->gl_name.ln_sbd, prev_object == NULL)) {
-               pr_warn("glock=%u/%llx\n",
-                       gl->gl_name.ln_type,
-                       (unsigned long long)gl->gl_name.ln_number);
+       if (gfs2_assert_warn(gl->gl_name.ln_sbd, prev_object == NULL))
                gfs2_dump_glock(NULL, gl, true);
-       }
 }
 
 /**
@@ -931,12 +927,8 @@ void glock_clear_object(struct gfs2_glock *gl, void *object)
        prev_object = gl->gl_object;
        gl->gl_object = NULL;
        spin_unlock(&gl->gl_lockref.lock);
-       if (gfs2_assert_warn(gl->gl_name.ln_sbd, prev_object == object)) {
-               pr_warn("glock=%u/%llx\n",
-                       gl->gl_name.ln_type,
-                       (unsigned long long)gl->gl_name.ln_number);
+       if (gfs2_assert_warn(gl->gl_name.ln_sbd, prev_object == object))
                gfs2_dump_glock(NULL, gl, true);
-       }
 }
 
 void gfs2_inode_remember_delete(struct gfs2_glock *gl, u64 generation)