]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemuBlockBitmapsHandleCommitFinish: Use proper variable to iterate
authorPeter Krempa <pkrempa@redhat.com>
Tue, 17 Mar 2020 14:31:12 +0000 (15:31 +0100)
committerPeter Krempa <pkrempa@redhat.com>
Tue, 17 Mar 2020 15:32:13 +0000 (16:32 +0100)
The function repeatedly checked the first element rather than iterating
through the array.

Reported-by: Daniel P. Berrangé <berrange@redhat.com>
Signed-off-by: Peter Krempa <pkrempa@redhat.com>
Reviewed-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
Tested-by: Daniel P. Berrangé <berrange@redhat.com>
src/qemu/qemu_block.c

index 115682c39d95e5020681fe96b141567b08aff79c..f95ebb6fa78a191efad11eca3a3e32faeda09c4c 100644 (file)
@@ -3177,7 +3177,7 @@ qemuBlockBitmapsHandleCommitFinish(virStorageSourcePtr topsrc,
                     char **disabledbitmaps;
 
                     for (disabledbitmaps = disabledBitmapsBase; *disabledbitmaps; disabledbitmaps++) {
-                        if (STREQ(*disabledBitmapsBase, bitmap->name)) {
+                        if (STREQ(*disabledbitmaps, bitmap->name)) {
                             bitmapdata = g_new0(struct qemuBlockBitmapsHandleCommitData, 1);
 
                             bitmapdata->create = false;