]> git.ipfire.org Git - thirdparty/pdns.git/commitdiff
QType ADDR is supposed to be used internally only.
authorOtto Moerbeek <otto.moerbeek@open-xchange.com>
Fri, 18 Feb 2022 15:24:11 +0000 (16:24 +0100)
committerOtto Moerbeek <otto.moerbeek@open-xchange.com>
Wed, 23 Feb 2022 06:31:09 +0000 (07:31 +0100)
Should fix #11337

pdns/recursor_cache.cc
pdns/recursordist/rec-taskqueue.cc

index 596ccbea91cf5029edc35d8979dd77974ede43de..cc3d5dfa86a657157bce0ed6ac6366068bed08c2 100644 (file)
@@ -252,7 +252,13 @@ time_t MemRecursorCache::fakeTTD(MemRecursorCache::OrderedTagIterator_t& entry,
       }
       else {
         if (!entry->d_submitted) {
-          pushAlmostExpiredTask(qname, qtype, entry->d_ttd);
+          if (qtype == QType::ADDR) {
+            pushAlmostExpiredTask(qname, QType::A, entry->d_ttd);
+            pushAlmostExpiredTask(qname, QType::AAAA, entry->d_ttd);
+          }
+         else {
+            pushAlmostExpiredTask(qname, qtype, entry->d_ttd);
+          }
           entry->d_submitted = true;
         }
       }
index 4180f0146dd5812d90fbad3ed6a9b96aac3f114b..d88e753563ad0955e5aa3f2323081161abeb81b4 100644 (file)
@@ -181,6 +181,14 @@ void runTaskOnce(bool logErrors)
 
 void pushAlmostExpiredTask(const DNSName& qname, uint16_t qtype, time_t deadline)
 {
+  switch (qtype) {
+    // Internal types
+  case QType::ENT:
+  case QType::ADDR:
+  case QType::ALIAS:
+  case QType::LUA:
+    return;
+  }
   pdns::ResolveTask task{qname, qtype, deadline, true, resolve};
   s_taskQueue.lock()->queue.push(std::move(task));
   ++s_almost_expired_tasks.pushed;