]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net: libwx: use request_irq for VF misc interrupt
authorJiawen Wu <jiawenwu@trustnetic.com>
Wed, 29 Apr 2026 08:37:43 +0000 (16:37 +0800)
committerJakub Kicinski <kuba@kernel.org>
Fri, 1 May 2026 01:07:21 +0000 (18:07 -0700)
Currently, request_threaded_irq() is used with a primary handler but a
NULL threaded handler, while also setting the IRQF_ONESHOT flag. This
specific combination triggers a WARNING since the commit aef30c8d569c
("genirq: Warn about using IRQF_ONESHOT without a threaded handler").

WARNING: kernel/irq/manage.c:1502 at __setup_irq+0x4fa/0x760

Fix the issue by switching to request_irq(), which is the appropriate
interface or a non-threaded interrupt handler, and removing the
unnecessary IRQF_ONESHOT flag.

Fixes: eb4898fde1de ("net: libwx: add wangxun vf common api")
Cc: stable@vger.kernel.org
Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
Link: https://patch.msgid.link/786DDC7D5CCA6D0A+20260429083743.88961-2-jiawenwu@trustnetic.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/wangxun/libwx/wx_vf_common.c

index 29cdbed2e5ecd3840b47dd4d4749da17b33f8c14..94ff8f5f0b4c8f7bfa245b91e6328f3ac3dd65ff 100644 (file)
@@ -99,8 +99,8 @@ int wx_request_msix_irqs_vf(struct wx *wx)
                }
        }
 
-       err = request_threaded_irq(wx->msix_entry->vector, wx_msix_misc_vf,
-                                  NULL, IRQF_ONESHOT, netdev->name, wx);
+       err = request_irq(wx->msix_entry->vector, wx_msix_misc_vf,
+                         0, netdev->name, wx);
        if (err) {
                wx_err(wx, "request_irq for msix_other failed: %d\n", err);
                goto free_queue_irqs;