]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: SDCA: Handle CONFIG_PM_SLEEP not being set
authorCharles Keepax <ckeepax@opensource.cirrus.com>
Thu, 15 Jan 2026 14:11:06 +0000 (14:11 +0000)
committerMark Brown <broonie@kernel.org>
Thu, 15 Jan 2026 18:58:24 +0000 (18:58 +0000)
If CONFIG_PM_SLEEP is not set the completion used will not exist. Update
the code to avoid the build error this introduces, without PM_SLEEP it
should be safe to always run the conditional code.

Fixes: ffd7e8a10111 ("ASoC: SDCA: Device boot into the system suspend process")
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202601151803.XY7KryHC-lkp@intel.com/
Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Link: https://patch.msgid.link/20260115141107.564929-1-ckeepax@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sdca/sdca_interrupts.c

index cc40732c30ccb8a741fb2aa7a60b9fa83d4e4702..d9e22cf40f77b732d395bfe440aa0d25b024e90c 100644 (file)
@@ -198,6 +198,18 @@ error:
        return irqret;
 }
 
+#ifdef CONFIG_PM_SLEEP
+static bool no_pm_in_progress(struct device *dev)
+{
+       return completion_done(&dev->power.completion);
+}
+#else
+static bool no_pm_in_progress(struct device *dev)
+{
+       return true;
+}
+#endif
+
 static irqreturn_t fdl_owner_handler(int irq, void *data)
 {
        struct sdca_interrupt *interrupt = data;
@@ -209,7 +221,7 @@ static irqreturn_t fdl_owner_handler(int irq, void *data)
         * FDL has to run from the system resume handler, at which point
         * we can't wait for the pm runtime.
         */
-       if (completion_done(&dev->power.completion)) {
+       if (no_pm_in_progress(dev)) {
                ret = pm_runtime_get_sync(dev);
                if (ret < 0) {
                        dev_err(dev, "failed to resume for fdl: %d\n", ret);
@@ -223,7 +235,7 @@ static irqreturn_t fdl_owner_handler(int irq, void *data)
 
        irqret = IRQ_HANDLED;
 error:
-       if (completion_done(&dev->power.completion))
+       if (no_pm_in_progress(dev))
                pm_runtime_put(dev);
        return irqret;
 }