]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
middle-end: skip checking loop exits if loop malformed [PR111878]
authorTamar Christina <tamar.christina@arm.com>
Thu, 16 Nov 2023 12:11:22 +0000 (12:11 +0000)
committerTamar Christina <tamar.christina@arm.com>
Thu, 16 Nov 2023 12:11:55 +0000 (12:11 +0000)
Before my refactoring if the loop->latch was incorrect then find_loop_location
skipped checking the edges and would eventually return a dummy location.

It turns out that a loop can have
loops_state_satisfies_p (LOOPS_HAVE_RECORDED_EXITS) but also not have a latch
in which case get_loop_exit_edges traps.

This restores the old behavior.

gcc/ChangeLog:

PR tree-optimization/111878
* tree-vect-loop-manip.cc (find_loop_location): Skip edges check if
latch incorrect.

gcc/testsuite/ChangeLog:

PR tree-optimization/111878
* gcc.dg/graphite/pr111878.c: New test.

gcc/testsuite/gcc.dg/graphite/pr111878.c [new file with mode: 0644]
gcc/tree-vect-loop-manip.cc

diff --git a/gcc/testsuite/gcc.dg/graphite/pr111878.c b/gcc/testsuite/gcc.dg/graphite/pr111878.c
new file mode 100644 (file)
index 0000000..6722910
--- /dev/null
@@ -0,0 +1,19 @@
+/* { dg-options "-O3 -fgraphite-identity -fsave-optimization-record" } */
+
+int long_c2i_ltmp;
+int *long_c2i_cont;
+
+void
+long_c2i (long utmp, int i)
+{
+  int neg = 1;
+  switch (long_c2i_cont[0])
+    case 0:
+    neg = 0;
+  for (; i; i++)
+    if (neg)
+      utmp |= long_c2i_cont[i] ^ 5;
+    else
+      utmp |= long_c2i_cont[i];
+  long_c2i_ltmp = utmp;
+}
index b9161274ce401a7307f3e61ad23aa036701190d7..bcd90a331f5ad3d44486d87b97fb0c6110bee0de 100644 (file)
@@ -1792,6 +1792,10 @@ find_loop_location (class loop *loop)
   if (!loop)
     return dump_user_location_t ();
 
+  /* For the root of the loop tree return the function location.  */
+  if (!loop_outer (loop))
+    return dump_user_location_t::from_function_decl (cfun->decl);
+
   if (loops_state_satisfies_p (LOOPS_HAVE_RECORDED_EXITS))
     {
       /* We only care about the loop location, so use any exit with location