]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
perf: arm_v7_pmu: Drop obvious comments for enabling/disabling counters and interrupts
authorRob Herring (Arm) <robh@kernel.org>
Tue, 18 Feb 2025 20:39:59 +0000 (14:39 -0600)
committerWill Deacon <will@kernel.org>
Sat, 1 Mar 2025 05:08:10 +0000 (05:08 +0000)
The function calls for enabling/disabling counters and interrupts are
pretty obvious as to what they are doing, and the comments don't add
any additional value.

Signed-off-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
Tested-by: James Clark <james.clark@linaro.org>
Link: https://lore.kernel.org/r/20250218-arm-brbe-v19-v20-4-4e9922fc2e8e@kernel.org
Signed-off-by: Will Deacon <will@kernel.org>
drivers/perf/arm_v7_pmu.c

index 420cadd108e79821f43537fab23fe081ca6fd9bc..7fa88e3b64e07bacbf2f9731e3318a7dc1085fb1 100644 (file)
@@ -857,14 +857,6 @@ static void armv7pmu_enable_event(struct perf_event *event)
                return;
        }
 
-       /*
-        * Enable counter and interrupt, and set the counter to count
-        * the event that we're interested in.
-        */
-
-       /*
-        * Disable counter
-        */
        armv7_pmnc_disable_counter(idx);
 
        /*
@@ -875,14 +867,7 @@ static void armv7pmu_enable_event(struct perf_event *event)
        if (cpu_pmu->set_event_filter || idx != ARMV7_IDX_CYCLE_COUNTER)
                armv7_pmnc_write_evtsel(idx, hwc->config_base);
 
-       /*
-        * Enable interrupt for this counter
-        */
        armv7_pmnc_enable_intens(idx);
-
-       /*
-        * Enable counter
-        */
        armv7_pmnc_enable_counter(idx);
 }
 
@@ -898,18 +883,7 @@ static void armv7pmu_disable_event(struct perf_event *event)
                return;
        }
 
-       /*
-        * Disable counter and interrupt
-        */
-
-       /*
-        * Disable counter
-        */
        armv7_pmnc_disable_counter(idx);
-
-       /*
-        * Disable interrupt for this counter
-        */
        armv7_pmnc_disable_intens(idx);
 }
 
@@ -1476,12 +1450,6 @@ static void krait_pmu_enable_event(struct perf_event *event)
        struct hw_perf_event *hwc = &event->hw;
        int idx = hwc->idx;
 
-       /*
-        * Enable counter and interrupt, and set the counter to count
-        * the event that we're interested in.
-        */
-
-       /* Disable counter */
        armv7_pmnc_disable_counter(idx);
 
        /*
@@ -1494,10 +1462,7 @@ static void krait_pmu_enable_event(struct perf_event *event)
        else
                armv7_pmnc_write_evtsel(idx, hwc->config_base);
 
-       /* Enable interrupt for this counter */
        armv7_pmnc_enable_intens(idx);
-
-       /* Enable counter */
        armv7_pmnc_enable_counter(idx);
 }
 
@@ -1797,12 +1762,6 @@ static void scorpion_pmu_enable_event(struct perf_event *event)
        struct hw_perf_event *hwc = &event->hw;
        int idx = hwc->idx;
 
-       /*
-        * Enable counter and interrupt, and set the counter to count
-        * the event that we're interested in.
-        */
-
-       /* Disable counter */
        armv7_pmnc_disable_counter(idx);
 
        /*
@@ -1815,10 +1774,7 @@ static void scorpion_pmu_enable_event(struct perf_event *event)
        else if (idx != ARMV7_IDX_CYCLE_COUNTER)
                armv7_pmnc_write_evtsel(idx, hwc->config_base);
 
-       /* Enable interrupt for this counter */
        armv7_pmnc_enable_intens(idx);
-
-       /* Enable counter */
        armv7_pmnc_enable_counter(idx);
 }