]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
efi: stmm: Make use of tee bus methods
authorUwe Kleine-König <u.kleine-koenig@baylibre.com>
Mon, 15 Dec 2025 14:16:39 +0000 (15:16 +0100)
committerJens Wiklander <jens.wiklander@linaro.org>
Wed, 7 Jan 2026 07:14:53 +0000 (08:14 +0100)
The tee bus got dedicated callbacks for probe and remove.
Make use of these. This fixes a runtime warning about the driver needing
to be converted to the bus methods.

Reviewed-by: Sumit Garg <sumit.garg@oss.qualcomm.com>
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
Reviewed-by: Ilias Apalodimas <ilias.apalodimas@linaro.org>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
drivers/firmware/efi/stmm/tee_stmm_efi.c

index 5903811858b6ef214e5c8ff413d41dd273b8aee1..7b04dd64962908897dd417a94ab8ff51bfcd9961 100644 (file)
@@ -520,8 +520,9 @@ static void tee_stmm_restore_efivars_generic_ops(void)
        efivars_generic_ops_register();
 }
 
-static int tee_stmm_efi_probe(struct device *dev)
+static int tee_stmm_efi_probe(struct tee_client_device *tee_dev)
 {
+       struct device *dev = &tee_dev->dev;
        struct tee_ioctl_open_session_arg sess_arg;
        efi_status_t ret;
        int rc;
@@ -571,21 +572,19 @@ static int tee_stmm_efi_probe(struct device *dev)
        return 0;
 }
 
-static int tee_stmm_efi_remove(struct device *dev)
+static void tee_stmm_efi_remove(struct tee_client_device *dev)
 {
        tee_stmm_restore_efivars_generic_ops();
-
-       return 0;
 }
 
 MODULE_DEVICE_TABLE(tee, tee_stmm_efi_id_table);
 
 static struct tee_client_driver tee_stmm_efi_driver = {
        .id_table       = tee_stmm_efi_id_table,
+       .probe          = tee_stmm_efi_probe,
+       .remove         = tee_stmm_efi_remove,
        .driver         = {
                .name           = "tee-stmm-efi",
-               .probe          = tee_stmm_efi_probe,
-               .remove         = tee_stmm_efi_remove,
        },
 };