]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: spacemit: add failure check for spacemit_i2s_init_dai()
authorTroy Mitchell <troy.mitchell@linux.spacemit.com>
Tue, 28 Oct 2025 01:32:09 +0000 (09:32 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 28 Oct 2025 10:17:34 +0000 (10:17 +0000)
Add error handling when memory allocation for dai fails in
spacemit_i2s_init_dai() call.

Reported-by: Dan Carpenter <dan.carpenter@linaro.org>
Closes: https://lore.kernel.org/all/aPtiNCZ_KBezL2Dr@stanley.mountain/#t
Fixes: fce217449075 ("ASoC: spacemit: add i2s support for K1 SoC")
Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
Closes: tag. It would be easy to make the argument that the
Link: https://patch.msgid.link/20251028-fix-k1-i2s-v2-1-a547c15ed5c3@linux.spacemit.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/spacemit/k1_i2s.c

index abc439b53e3d4358570df2e69e636bf54820d9ce..8af05e1604f518b63cbbbaa66b73cfee8262d87f 100644 (file)
@@ -428,7 +428,9 @@ static int spacemit_i2s_probe(struct platform_device *pdev)
 
        dev_set_drvdata(i2s->dev, i2s);
 
-       spacemit_i2s_init_dai(i2s, &dai, res->start + SSDATR);
+       ret = spacemit_i2s_init_dai(i2s, &dai, res->start + SSDATR);
+       if (ret)
+               return ret;
 
        ret = devm_snd_soc_register_component(i2s->dev,
                                              &spacemit_i2s_component,