gpio: sloppy-logic-analyzer: Fix memory leak in gpio_la_poll_probe()

The memory allocated for priv->blob.data is not freed in the error paths
that follow the fops_buf_size_set() call in gpio_la_poll_probe(), as
well as in the remove function. Fix that by using device managed action
to free the memory on remove.

Fixes: 7828b7bbbf20 ("gpio: add sloppy logic analyzer using polling")
Signed-off-by: Abdun Nihaal <nihaal@cse.iitm.ac.in>
Reviewed-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Link: https://patch.msgid.link/20260715075311.527753-1-nihaal@cse.iitm.ac.in
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com>

diff --git a/drivers/gpio/gpio-sloppy-logic-analyzer.c b/drivers/gpio/gpio-sloppy-logic-analyzer.c
index 2bbd308ca08e6b7fde277c0e7e066dcaebc30c29..aa23b5779802a24d77cb1450e4ffa8981ec51163 100644 (file)
--- a/drivers/gpio/gpio-sloppy-logic-analyzer.c
+++ b/drivers/gpio/gpio-sloppy-logic-analyzer.c
@@ -160,6 +160,13 @@ static int fops_buf_size_get(void *data, u64 *val)
        return 0;
 }
 
+static void fops_buf_release(void *data)
+{
+       struct gpio_la_poll_priv *priv = data;
+
+       vfree(priv->blob.data);
+}
+
 static int fops_buf_size_set(void *data, u64 val)
 {
        struct gpio_la_poll_priv *priv = data;
@@ -238,6 +245,9 @@ static int gpio_la_poll_probe(struct platform_device *pdev)
                return ret;
 
        fops_buf_size_set(priv, GPIO_LA_DEFAULT_BUF_SIZE);
+       ret = devm_add_action_or_reset(dev, fops_buf_release, priv);
+       if (ret)
+               return ret;
 
        priv->descs = devm_gpiod_get_array(dev, "probe", GPIOD_IN);
        if (IS_ERR(priv->descs))