ASoC: codecs: wcd939x-sdw: use devres for regmap allocation

Components are bound inside a new devres group so that any resources
allocated can be released on bind failure and on unbind without
affecting anything else.

Switch to using device managed regmap allocation for consistency while
dropping the misleading comment claiming that devres cannot be used.

Cc: Neil Armstrong <neil.armstrong@linaro.org>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20251201092259.11761-1-johan@kernel.org
Signed-off-by: Mark Brown <broonie@kernel.org>

diff --git a/sound/soc/codecs/wcd939x-sdw.c b/sound/soc/codecs/wcd939x-sdw.c
index da342a0c95a52bc9a872cfac23d7a874c7efc633..399dfba79aa2436e4dea737e6bc2e3c4b89a6f41 100644 (file)
--- a/sound/soc/codecs/wcd939x-sdw.c
+++ b/sound/soc/codecs/wcd939x-sdw.c
@@ -1384,12 +1384,7 @@ static int wcd9390_probe(struct sdw_slave *pdev, const struct sdw_device_id *id)
        }
 
        if (wcd->is_tx) {
-               /*
-                * Do not use devres here since devres_release_group() could
-                * be called by component_unbind() id the aggregate device
-                * fails to bind.
-                */
-               wcd->regmap = regmap_init_sdw(pdev, &wcd939x_regmap_config);
+               wcd->regmap = devm_regmap_init_sdw(pdev, &wcd939x_regmap_config);
                if (IS_ERR(wcd->regmap))
                        return dev_err_probe(dev, PTR_ERR(wcd->regmap),
                                             "Regmap init failed\n");
@@ -1400,30 +1395,20 @@ static int wcd9390_probe(struct sdw_slave *pdev, const struct sdw_device_id *id)
 
        ret = component_add(dev, &wcd_sdw_component_ops);
        if (ret)
-               goto err_free_regmap;
+               return ret;
 
        /* Set suspended until aggregate device is bind */
        pm_runtime_set_suspended(dev);
 
        return 0;
-
-err_free_regmap:
-       if (wcd->regmap)
-               regmap_exit(wcd->regmap);
-
-       return ret;
 }
 
 static int wcd9390_remove(struct sdw_slave *pdev)
 {
        struct device *dev = &pdev->dev;
-       struct wcd939x_sdw_priv *wcd = dev_get_drvdata(dev);
 
        component_del(dev, &wcd_sdw_component_ops);
 
-       if (wcd->regmap)
-               regmap_exit(wcd->regmap);
-
        return 0;
 }