]> git.ipfire.org Git - thirdparty/kea.git/commitdiff
[#3074] addressed review comments
authorPiotrek Zadroga <piotrek@isc.org>
Wed, 22 Nov 2023 15:57:03 +0000 (16:57 +0100)
committerPiotrek Zadroga <piotrek@isc.org>
Tue, 9 Jan 2024 10:40:04 +0000 (11:40 +0100)
src/lib/dhcp/option_classless_static_route.cc

index 5d3620386f253b9c470a534d565a5824d82e6e00..dd032dbb708820071e225a0ff63cff4af3563363 100644 (file)
@@ -119,7 +119,7 @@ OptionClasslessStaticRoute::encodeDestinationDescriptor(const StaticRouteTuple&
 
 uint8_t
 OptionClasslessStaticRoute::calcSignificantOctets(const uint8_t& mask_width) {
-    return (mask_width / 8 + (mask_width % 8 != 0));
+    return ((mask_width + 7) / 8);
 }
 
 void
@@ -129,7 +129,7 @@ OptionClasslessStaticRoute::calcDataLen() {
         // 1-5 octets of destination descriptor
         len += calcSignificantOctets(std::get<1>(route)) + 1;
         // IP address of the router
-        len += 4;
+        len += V4ADDRESS_LEN;
     }
 
     data_len_ = len;