www: mail_diff: add final newline before diffing

This gets rid of the "\ No newline at end of file"
since it's distracting noise.

diff --git a/lib/PublicInbox/MailDiff.pm b/lib/PublicInbox/MailDiff.pm
index 98284b23a59ed36fd72fef1a13d44b3807d5245f..89284e39c37e536cbef999652a0ad4680395c6ab 100644 (file)
--- a/lib/PublicInbox/MailDiff.pm
+++ b/lib/PublicInbox/MailDiff.pm
@@ -24,7 +24,7 @@ sub write_part { # Eml->each_part callback
        $s //= $part->body;
        $s =~ s/\r\n/\n/gs; # TODO: consider \r+\n to match View
        $s =~ s/\s*\z//s;
-       write_file '>:utf8', "$self->{curdir}/$idx.$sfx", $s;
+       write_file '>:utf8', "$self->{curdir}/$idx.$sfx", $s, "\n";
 }
 
 # public

diff --git a/t/lei-mail-diff.t b/t/lei-mail-diff.t
index 9398596aba0d25bd6eeee675323fb6e0a047936d..1a896e515d8f11c8c0ee5e5d0b95af521f887a5c 100644 (file)
--- a/t/lei-mail-diff.t
+++ b/t/lei-mail-diff.t
@@ -7,6 +7,7 @@ test_lei(sub {
        ok(!lei('mail-diff', 't/data/0001.patch', 't/data/binary.patch'),
                'different messages are different');
        like($lei_out, qr/^\+/m, 'diff shown');
+       unlike $lei_out, qr/No newline at end of file/;
        lei_ok('mail-diff', 't/data/0001.patch', 't/data/0001.patch');
        is($lei_out, '', 'no output if identical');
 });

diff --git a/t/psgi_v2.t b/t/psgi_v2.t
index 5ccaab19964aa8e77d2557899d13113abf2f604b..54faae9b4c60801ddf23e57e5497dddfa1d307c5 100644 (file)
--- a/t/psgi_v2.t
+++ b/t/psgi_v2.t
@@ -287,6 +287,7 @@ my $client1 = sub {
                'cr_mismatch is only diff context');
        like($raw, qr!>\-pipe !s, 'pipe diff del line');
        like($raw, qr!>\+pipe !s, 'pipe diff ins line');
+       unlike $raw, qr/No newline at end of file/;
 };
 
 test_psgi(sub { $www->call(@_) }, $client1);