]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net: xilinx_emaclite: Do not print real IOMEM pointer
authorYueHaibing <yuehaibing@huawei.com>
Wed, 19 May 2021 02:47:04 +0000 (10:47 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 08:00:47 +0000 (10:00 +0200)
[ Upstream commit d0d62baa7f505bd4c59cd169692ff07ec49dde37 ]

Printing kernel pointers is discouraged because they might leak kernel
memory layout.  This fixes smatch warning:

drivers/net/ethernet/xilinx/xilinx_emaclite.c:1191 xemaclite_of_probe() warn:
 argument 4 to %08lX specifier is cast from pointer

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/ethernet/xilinx/xilinx_emaclite.c

index 007840d4a8073e2bb5aede5a5222c6af20821af2..3ffe8d2a1f14bb1b094cc0eb4c21a6c5088c3790 100644 (file)
@@ -1193,9 +1193,8 @@ static int xemaclite_of_probe(struct platform_device *ofdev)
        }
 
        dev_info(dev,
-                "Xilinx EmacLite at 0x%08lX mapped to 0x%08lX, irq=%d\n",
-                (unsigned long __force)ndev->mem_start,
-                (unsigned long __force)lp->base_addr, ndev->irq);
+                "Xilinx EmacLite at 0x%08lX mapped to 0x%p, irq=%d\n",
+                (unsigned long __force)ndev->mem_start, lp->base_addr, ndev->irq);
        return 0;
 
 error: