]> git.ipfire.org Git - thirdparty/openssl.git/commitdiff
Fix state handling of sha3_absorb for s390x.
authorHolger Dengler <dengler@linux.ibm.com>
Wed, 27 Sep 2023 13:36:23 +0000 (15:36 +0200)
committerHolger Dengler <dengler@linux.ibm.com>
Fri, 10 Nov 2023 13:26:27 +0000 (14:26 +0100)
The digest life-cycle state diagram has been updated for XOF. Fix the
state handling in s390x_sha3_aborb() according to the updated state
diagram.

Signed-off-by: Holger Dengler <dengler@linux.ibm.com>
Reviewed-by: Shane Lontis <shane.lontis@oracle.com>
Reviewed-by: Todd Short <todd.short@me.com>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/22221)

providers/implementations/digests/sha3_prov.c

index 13735153f2daa4464b142f2b4a92a6540db79d86..85370912f62b1bd40aa26a8012697a3a7c080eba 100644 (file)
@@ -188,6 +188,10 @@ static size_t s390x_sha3_absorb(void *vctx, const void *inp, size_t len)
     KECCAK1600_CTX *ctx = vctx;
     size_t rem = len % ctx->block_size;
 
+    if (!(ctx->xof_state == XOF_STATE_INIT ||
+          ctx->xof_state == XOF_STATE_ABSORB))
+        return 0;
+    ctx->xof_state = XOF_STATE_ABSORB;
     s390x_kimd(inp, len - rem, ctx->pad, ctx->A);
     return rem;
 }