]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
ocfs2: remove redundant error code assignment
authorAlexey Velichayshiy <a.velichayshiy@ispras.ru>
Sat, 7 Mar 2026 23:47:53 +0000 (02:47 +0300)
committerAndrew Morton <akpm@linux-foundation.org>
Sat, 28 Mar 2026 04:19:44 +0000 (21:19 -0700)
Remove the error assignment for variable 'ret' during correct code
execution.  In subsequent execution, variable 'ret' is overwritten.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Link: https://lkml.kernel.org/r/20260307234809.88421-1-a.velichayshiy@ispras.ru
Signed-off-by: Alexey Velichayshiy <a.velichayshiy@ispras.ru>
Acked-by: Joseph Qi <joseph.qi@linux.alibaba.com>
Cc: Mark Fasheh <mark@fasheh.com>
Cc: Joel Becker <jlbec@evilplan.org>
Cc: Junxiao Bi <junxiao.bi@oracle.com>
Cc: Changwei Ge <gechangwei@live.cn>
Cc: Jun Piao <piaojun@huawei.com>
Cc: Heming Zhao <heming.zhao@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
fs/ocfs2/dlm/dlmmaster.c

index eb62724bbe9bb3215bc2c2b3d3b8b261126b2a3b..93eff38fdaddb64da3513d8a2741d765607ac15a 100644 (file)
@@ -930,7 +930,6 @@ redo_request:
        if (blocked)
                goto wait;
 
-       ret = -EINVAL;
        dlm_node_iter_init(mle->vote_map, &iter);
        while ((nodenum = dlm_node_iter_next(&iter)) >= 0) {
                ret = dlm_do_master_request(res, mle, nodenum);