]> git.ipfire.org Git - thirdparty/asterisk.git/commitdiff
security fix. really drop call if signalling addr is not same as socket
authorAlexandr Anikin <may@telecom-service.ru>
Tue, 30 Aug 2011 21:53:42 +0000 (21:53 +0000)
committerAlexandr Anikin <may@telecom-service.ru>
Tue, 30 Aug 2011 21:53:42 +0000 (21:53 +0000)
addr

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/10@333962 65c4cc65-6c06-0410-ace0-fbb531ad65f3

addons/ooh323c/src/ooh323.c

index 0c8f517fb1e076adeb6fb0ea73da2c106f647496..08a4b1d1e40b9e6ca7c3e3b8ce98bc32c7282e97 100644 (file)
@@ -371,7 +371,7 @@ int ooOnReceivedSetup(OOH323CallData *call, Q931Message *q931Msg)
    H225TransportAddress_ip6Address_ip *ip6 = NULL;
    Q931InformationElement* pDisplayIE=NULL;
    OOAliases *pAlias=NULL;
-   char remoteIP[2+8*4+7];
+   char remoteIP[2+8*4+7] = "";
 
    call->callReference = q931Msg->callReference;
  
@@ -529,6 +529,7 @@ int ooOnReceivedSetup(OOH323CallData *call, Q931Message *q931Msg)
      OOTRACEERR5("ERROR: Security denial remote sig IP isn't a socket ip, %s not %s "
                     "(%s, %s)\n", remoteIP, call->remoteIP, call->callType, 
                     call->callToken);
+     return OO_FAILED;
    }
    
    /* check for fast start */