Fix return code check

diff --git a/src/bin/fuzzer.c b/src/bin/fuzzer.c
index e9ca57bcb0de2394077bb0ece6ea26c740a38fe0..5c941f42d6f2530bff597668ba8276ed1b833691 100644 (file)
--- a/src/bin/fuzzer.c
+++ b/src/bin/fuzzer.c
@@ -53,7 +53,7 @@ int LLVMFuzzerInitialize(UNUSED int *argc, UNUSED char ***argv)
 
        if (!dict_dir) dict_dir = DICTDIR;
 
-       if (fr_dict_global_init(NULL, dict_dir) < 0) {
+       if (!fr_dict_global_init(NULL, dict_dir)) {
                fr_perror("dict_global");
                return 0;
        }

diff --git a/src/bin/radclient.c b/src/bin/radclient.c
index 87d9e968de1fd5ef4575663ace480d6b336c9012..41cbe314d8d13e260f692e1e0be78f194e4e6554 100644 (file)
--- a/src/bin/radclient.c
+++ b/src/bin/radclient.c
@@ -1370,7 +1370,7 @@ int main(int argc, char **argv)
                return 1;
        }
 
-       if (fr_dict_global_init(autofree, dict_dir) < 0) {
+       if (!fr_dict_global_init(autofree, dict_dir)) {
                fr_perror("radclient");
                return 1;
        }

diff --git a/src/bin/radict.c b/src/bin/radict.c
index cd5f436f740c9ae7de8d0d2028226fdf2b092f13..00eaea9a3c9d68d3446805f8adcf65034c7a3b53 100644 (file)
--- a/src/bin/radict.c
+++ b/src/bin/radict.c
@@ -240,7 +240,7 @@ int main(int argc, char *argv[])
                goto finish;
        }
 
-       if (fr_dict_global_init(autofree, dict_dir) < 0) {
+       if (!fr_dict_global_init(autofree, dict_dir)) {
                fr_perror("radict");
                ret = 1;
                goto finish;

diff --git a/src/bin/radiusd.c b/src/bin/radiusd.c
index 51b30857e32a74665e126360c49704ccbd27de39..c3a6e12c83e6b36c29c62843f71bbb9125137c78 100644 (file)
--- a/src/bin/radiusd.c
+++ b/src/bin/radiusd.c
@@ -495,7 +495,7 @@ int main(int argc, char *argv[])
         *      Initialise the top level dictionary hashes which hold
         *      the protocols.
         */
-       if (fr_dict_global_init(global_ctx, config->dict_dir) < 0) {
+       if (!fr_dict_global_init(global_ctx, config->dict_dir)) {
                fr_perror("%s", program);
                EXIT_WITH_FAILURE;
        }

diff --git a/src/bin/radsniff.c b/src/bin/radsniff.c
index 552a07b624478f1a28375f4f595ddd05aa45d570..e8a0811d9c280db356357a8592c0136a0950bf2b 100644 (file)
--- a/src/bin/radsniff.c
+++ b/src/bin/radsniff.c
@@ -2561,7 +2561,7 @@ int main(int argc, char *argv[])
                                                         conf->pcap_filter, conf->pcap_filter);
        }
 
-       if (fr_dict_global_init(conf, dict_dir) < 0) {
+       if (!fr_dict_global_init(conf, dict_dir)) {
                fr_perror("radsniff");
                exit(EXIT_FAILURE);
        }

diff --git a/src/bin/radwho.c b/src/bin/radwho.c
index 0485ca5cfbaa27dd6371619d9df23d026e1875f8..05f773e7ee9dcdd99318f2816f0bded6f1018e43 100644 (file)
--- a/src/bin/radwho.c
+++ b/src/bin/radwho.c
@@ -299,7 +299,7 @@ int main(int argc, char **argv)
                return 1;
        }
 
-       if (fr_dict_global_init(autofree, config->dict_dir) < 0) {
+       if (!fr_dict_global_init(autofree, config->dict_dir)) {
                fr_perror("%s", main_config->name);
                exit(EXIT_FAILURE);
        }

diff --git a/src/bin/unit_test_attribute.c b/src/bin/unit_test_attribute.c
index d79f6762e401c8d0f40395aea74eccac8a55385e..339fb43cfdf215d4edee32da3769f62e4f2b0c5f 100644 (file)
--- a/src/bin/unit_test_attribute.c
+++ b/src/bin/unit_test_attribute.c
@@ -2286,7 +2286,7 @@ int main(int argc, char *argv[])
                EXIT_WITH_FAILURE;
        }
 
-       if (fr_dict_global_init(autofree, dict_dir) < 0) {
+       if (!fr_dict_global_init(autofree, dict_dir)) {
                fr_perror("unit_test_attribute");
                EXIT_WITH_FAILURE;
        }

diff --git a/src/bin/unit_test_map.c b/src/bin/unit_test_map.c
index 1581b902e075dfecef5c58a5251aa7658c9f504e..55efa88f68a98ff0a7c8a105ffb1a971209a2087 100644 (file)
--- a/src/bin/unit_test_map.c
+++ b/src/bin/unit_test_map.c
@@ -204,7 +204,7 @@ int main(int argc, char *argv[])
                EXIT_WITH_FAILURE;
        }
 
-       if (fr_dict_global_init(autofree, dict_dir) < 0) {
+       if (!fr_dict_global_init(autofree, dict_dir)) {
                fr_perror("unit_test_map");
                EXIT_WITH_FAILURE;
        }

diff --git a/src/bin/unit_test_module.c b/src/bin/unit_test_module.c
index 4f7edad27690ca6d17b3b340b04000be3965f536..fa0e51e21334ca3fe277dd8d940f13a3ef3ed34f 100644 (file)
--- a/src/bin/unit_test_module.c
+++ b/src/bin/unit_test_module.c
@@ -746,7 +746,7 @@ int main(int argc, char *argv[])
                EXIT_WITH_FAILURE;
        }
 
-       if (fr_dict_global_init(autofree, config->dict_dir) < 0) {
+       if (!fr_dict_global_init(autofree, config->dict_dir)) {
                fr_perror("%s", config->name);
                EXIT_WITH_FAILURE;
        }

diff --git a/src/modules/proto_control/radmin.c b/src/modules/proto_control/radmin.c
index 4b33498f37cd1e9c4169963450f3199d2ace1d7d..c7ac24fc1ee7f30911f5db63336d9f6f2d2dac6b 100644 (file)
--- a/src/modules/proto_control/radmin.c
+++ b/src/modules/proto_control/radmin.c
@@ -950,7 +950,7 @@ int main(int argc, char **argv)
                 *      Need to read in the dictionaries, else we may get
                 *      validation errors when we try and parse the config.
                 */
-               if (fr_dict_global_init(autofree, dict_dir) < 0) {
+               if (!fr_dict_global_init(autofree, dict_dir)) {
                        fr_perror("radmin");
                        exit(64);
                }

diff --git a/src/modules/proto_dhcpv4/dhcpclient.c b/src/modules/proto_dhcpv4/dhcpclient.c
index 67d2545d18593082fe1a542b1ac2c939f1505d4f..eaf028c584e4ca1272c313cc6fa52e80701b55cb 100644 (file)
--- a/src/modules/proto_dhcpv4/dhcpclient.c
+++ b/src/modules/proto_dhcpv4/dhcpclient.c
@@ -662,7 +662,7 @@ int main(int argc, char **argv)
 
        if (argc < 2) usage();
 
-       if (fr_dict_global_init(autofree, dict_dir) < 0) {
+       if (!fr_dict_global_init(autofree, dict_dir)) {
                fr_perror("dhcpclient");
                exit(EXIT_FAILURE);
        }

diff --git a/src/modules/proto_ldap_sync/sync_touch.c b/src/modules/proto_ldap_sync/sync_touch.c
index cceed73b9a23e4abb927e424b19c690db2c5028c..140ffee070566c4e29e3edab36138f890185b23d 100644 (file)
--- a/src/modules/proto_ldap_sync/sync_touch.c
+++ b/src/modules/proto_ldap_sync/sync_touch.c
@@ -133,7 +133,7 @@ int main(int argc, char **argv)
                exit(EXIT_FAILURE);
        }
 
-       if (fr_dict_global_init(autofree, dict_dir) < 0) {
+       if (!fr_dict_global_init(autofree, dict_dir)) {
                fr_perror("sync_touch");
                exit(EXIT_FAILURE);
        }