]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
coverity: #1425813
authorChristian Brauner <christian.brauner@ubuntu.com>
Fri, 15 Jun 2018 09:49:10 +0000 (11:49 +0200)
committerChristian Brauner <christian.brauner@ubuntu.com>
Mon, 10 Dec 2018 08:22:11 +0000 (09:22 +0100)
Resource leak

Signed-off-by: Christian Brauner <christian.brauner@ubuntu.com>
src/lxc/tools/lxc_ls.c

index a7e0ed22073b1cba936169704ade3f4d45e94dde..7f170e8c302663cacfafddd54e4676404a628e16 100644 (file)
@@ -561,8 +561,10 @@ static int ls_get(struct ls **m, size_t *size, const struct lxc_arguments *args,
                        /* We want to remove all locks we create under
                         * /run/lxc/lock so we create a string pointing us to
                         * the lock path for the current container. */
-                       if (ls_remove_lock(path, name, lockpath, &len_lockpath, true) == -1)
+                       if (ls_remove_lock(path, name, lockpath, &len_lockpath, true) == -1) {
+                               free(newpath);
                                goto put_and_next;
+                       }
 
                        ls_get(m, size, args, newpath, l->name, lvl + 1, lockpath, len_lockpath, grps_must, grps_must_len);
                        free(newpath);