Pull request #3549: crashhandler: Crashandler signal handling path Fix

Merge in SNORT/snort3 from ~MSONEJA/snort3:crash_handler_fix to master

Squashed commit of the following:

commit c880afa890d8b451968f1dd7aa895ccbaf57f689
Author: msoneja <msoneja@cisco.com>
Date:   Wed Aug 10 11:36:34 2022 +0000

    helpers: make install_oops_handle and remove_oops_handle so_public, install process.h and sigsafe.h

diff --git a/src/helpers/CMakeLists.txt b/src/helpers/CMakeLists.txt
index 33059c92f8855a949083024e18700fdae2eb8fc9..de23cd7f02b6c10f4be7be78cf66671b30915314 100644 (file)
--- a/src/helpers/CMakeLists.txt
+++ b/src/helpers/CMakeLists.txt
@@ -13,12 +13,14 @@ endif ()
 set (HELPERS_INCLUDES
     ${HYPER_HEADERS}
     base64_encoder.h
-    buffer_data.h
+    bitop.h
     boyer_moore_search.h
+    buffer_data.h
+    json_stream.h
     literal_search.h
+    process.h
     scratch_allocator.h
-    json_stream.h
-    bitop.h
+    sigsafe.h
 )
 
 add_library (helpers OBJECT
@@ -40,11 +42,9 @@ add_library (helpers OBJECT
     markup.cc
     markup.h
     process.cc
-    process.h
     ring.h
     ring_logic.h
     sigsafe.cc
-    sigsafe.h
     scratch_allocator.cc
 )
 

diff --git a/src/helpers/process.h b/src/helpers/process.h
index 885252a62e926736ab73b21c2ea3cb27fb379e51..24048a97de4e82679c5a537f981e7c493d42fdbb 100644 (file)
--- a/src/helpers/process.h
+++ b/src/helpers/process.h
@@ -19,6 +19,8 @@
 #ifndef PROCESS_H
 #define PROCESS_H
 
+#include "main/snort_types.h"
+
 // process oriented services like signal handling, heap info, etc.
 
 enum PigSignal
@@ -39,8 +41,8 @@ const char* get_signal_name(PigSignal);
 
 void init_signals();
 void term_signals();
-void install_oops_handler();
-void remove_oops_handler();
+SO_PUBLIC void install_oops_handler();
+SO_PUBLIC void remove_oops_handler();
 void help_signals();
 
 void daemonize();

diff --git a/src/helpers/sigsafe.h b/src/helpers/sigsafe.h
index 178cfacb132b00126129fdf76b64bf6410708e81..4f0efef629d22f92679790e2d941b06b4787fed3 100644 (file)
--- a/src/helpers/sigsafe.h
+++ b/src/helpers/sigsafe.h
@@ -23,7 +23,9 @@
 #include <cstddef>
 #include <cstdint>
 
-class SigSafePrinter
+#include "main/snort_types.h"
+
+class SO_PUBLIC SigSafePrinter
 {
 public:
     SigSafePrinter(char *buf, size_t size);