]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: iwlwifi: fix cmd length when sending WOWLAN_TSC_RSC_PARAM
authorAntonio Quartulli <antonio@mandelbit.com>
Wed, 16 Jul 2025 20:19:11 +0000 (22:19 +0200)
committerMiri Korenblit <miriam.rachel.korenblit@intel.com>
Tue, 22 Jul 2025 03:13:53 +0000 (06:13 +0300)
In iwl_mvm_wowlan_config_rsc_tsc() when calling iwl_mvm_send_cmd_pdu()
we are accidentally passing the size of a pointer rather than the size
of the object pointed by it.

Fix the expression in order to pass the approriate object length.

Fixes: 493681d9f95b ("wifi: iwlwifi: remove support of version 4 of iwl_wowlan_rsc_tsc_params_cmd")
Address-Coverity-ID: 1647627 ("Incorrect expression  (SIZEOF_MISMATCH)")
Signed-off-by: Antonio Quartulli <antonio@mandelbit.com>
Link: https://patch.msgid.link/20250716201911.700-1-antonio@mandelbit.com
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/d3.c

index ef9bab0429026b98b3452833c90c40e3d5724a3b..b8754d7e51c5f6046f478f08dd2c241fae2a0557 100644 (file)
@@ -494,7 +494,7 @@ static int iwl_mvm_wowlan_config_rsc_tsc(struct iwl_mvm *mvm,
                if (data.have_rsc_tsc)
                        ret = iwl_mvm_send_cmd_pdu(mvm, WOWLAN_TSC_RSC_PARAM,
                                                   CMD_ASYNC,
-                                                  sizeof(data.rsc_tsc),
+                                                  sizeof(*data.rsc_tsc),
                                                   data.rsc_tsc);
                else
                        ret = 0;