]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
watchdog: rzv2h_wdt: Discard pm_runtime_put() return value
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Mon, 22 Dec 2025 20:09:22 +0000 (21:09 +0100)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 8 Jan 2026 20:36:51 +0000 (21:36 +0100)
Failing device probe due to pm_runtime_put() returning an error is not
particularly useful.

Returning an error code from pm_runtime_put() merely means that it has
not queued up a work item to check whether or not the device can be
suspended and there are many perfectly valid situations in which that
can happen, like after writing "on" to the devices' runtime PM "control"
attribute in sysfs for one example.  It also happens when the kernel is
configured with CONFIG_PM unset.

Accordingly, update rzt2h_wdt_wdtdcr_init() to simply discard the return
value of pm_runtime_put() and return success to the caller after
invoking that function.

This will facilitate a planned change of the pm_runtime_put() return
type to void in the future.

Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://patch.msgid.link/1867890.VLH7GnMWUR@rafael.j.wysocki
drivers/watchdog/rzv2h_wdt.c

index f93647934db74b7bb847b7d122e9df63d012f537..3b6abb66a1da0012b98e931ac8c4b4b060479f34 100644 (file)
@@ -268,9 +268,7 @@ static int rzt2h_wdt_wdtdcr_init(struct platform_device *pdev,
 
        rzt2h_wdt_wdtdcr_count_stop(priv);
 
-       ret = pm_runtime_put(&pdev->dev);
-       if (ret < 0)
-               return ret;
+       pm_runtime_put(&pdev->dev);
 
        return 0;
 }