]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
erofs: set error to bio if file-backed IO fails
authorSheng Yong <shengyong1@xiaomi.com>
Tue, 8 Apr 2025 12:23:50 +0000 (20:23 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 20 Apr 2025 08:15:28 +0000 (10:15 +0200)
[ Upstream commit 1595f15391b81815e4ef91c339991913d556c1b6 ]

If a file-backed IO fails before submitting the bio to the lower
filesystem, an error is returned, but the bio->bi_status is not
marked as an error. However, the error information should be passed
to the end_io handler. Otherwise, the IO request will be treated as
successful.

Fixes: 283213718f5d ("erofs: support compressed inodes for fileio")
Signed-off-by: Sheng Yong <shengyong1@xiaomi.com>
Reviewed-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Link: https://lore.kernel.org/r/20250408122351.2104507-1-shengyong1@xiaomi.com
Signed-off-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/erofs/fileio.c

index 33f8539dda4aebab3a46040bbddcd6e15f2f6e79..17aed5f6c5490db59473e9345cae10f12da3c78b 100644 (file)
@@ -32,6 +32,8 @@ static void erofs_fileio_ki_complete(struct kiocb *iocb, long ret)
                ret = 0;
        }
        if (rq->bio.bi_end_io) {
+               if (ret < 0 && !rq->bio.bi_status)
+                       rq->bio.bi_status = errno_to_blk_status(ret);
                rq->bio.bi_end_io(&rq->bio);
        } else {
                bio_for_each_folio_all(fi, &rq->bio) {