]> git.ipfire.org Git - thirdparty/bootstrap.git/commitdiff
Added type="button" to <button>s without any type (#27174)
authorHerst <Herst@users.noreply.github.com>
Mon, 3 Sep 2018 15:55:04 +0000 (17:55 +0200)
committerPatrick H. Lauke <redux@splintered.co.uk>
Mon, 3 Sep 2018 15:55:04 +0000 (16:55 +0100)
(again)

https://github.com/twbs/bootlint/wiki/W007

site/docs/4.1/assets/js/src/application.js
site/docs/4.1/components/modal.md
site/docs/4.1/examples/dashboard/index.html

index 7666da065d6d0ebc8e067c5bb7aa403c10963da3..6938b9ebe9a6866388ab582f416be9bad11fac36 100644 (file)
@@ -54,7 +54,7 @@
 
     // Insert copy to clipboard button before .highlight
     $('figure.highlight, div.highlight').each(function () {
-      var btnHtml = '<div class="bd-clipboard"><button class="btn-clipboard" title="Copy to clipboard">Copy</button></div>'
+      var btnHtml = '<div class="bd-clipboard"><button type="button" class="btn-clipboard" title="Copy to clipboard">Copy</button></div>'
       $(this).before(btnHtml)
       $('.btn-clipboard')
         .tooltip()
index 2da7d8f3c3d3bf937cbc9e7c872eb2cb45868f6d..a29347b6f35e646b53036e12c07cca7d0a647207 100644 (file)
@@ -522,7 +522,7 @@ Our default modal without modifier class constitutes the "medium" size modal.
 
 {% highlight html %}
 <!-- Extra large modal -->
-<button class="btn btn-primary" data-toggle="modal" data-target=".bd-example-modal-xl">Extra large modal</button>
+<button type="button" class="btn btn-primary" data-toggle="modal" data-target=".bd-example-modal-xl">Extra large modal</button>
 
 <div class="modal fade bd-example-modal-xl" tabindex="-1" role="dialog" aria-labelledby="myExtraLargeModalLabel" aria-hidden="true">
   <div class="modal-dialog modal-xl">
index f66c4505dd4bd616814551c0710328cb27f72291..3578f7a7470cd9aafbc5b610255f89759828f8ac 100644 (file)
             <h1 class="h2">Dashboard</h1>
             <div class="btn-toolbar mb-2 mb-md-0">
               <div class="btn-group mr-2">
-                <button class="btn btn-sm btn-outline-secondary">Share</button>
-                <button class="btn btn-sm btn-outline-secondary">Export</button>
+                <button type="button" class="btn btn-sm btn-outline-secondary">Share</button>
+                <button type="button" class="btn btn-sm btn-outline-secondary">Export</button>
               </div>
-              <button class="btn btn-sm btn-outline-secondary dropdown-toggle">
+              <button type="button" class="btn btn-sm btn-outline-secondary dropdown-toggle">
                 <span data-feather="calendar"></span>
                 This week
               </button>