]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
Relax the Python version check for `__class_getitem__` tests 7049/head
authorlayday <layday@protonmail.com>
Sun, 19 Sep 2021 11:54:54 +0000 (14:54 +0300)
committerlayday <layday@protonmail.com>
Sun, 19 Sep 2021 11:54:54 +0000 (14:54 +0300)
`__class_getitem__` to support generics was introduced in Python 3.7.
In 3.9 some built-ins were made generic but the functionality
for user-defined classes has been there since 3.7.

lib/sqlalchemy/testing/requirements.py
test/base/test_misc_py3k.py

index 40127addfb4b481f616d3fe404fae3f891b5da7f..f6e79042c99617a133b294b67be0867c2e871536 100644 (file)
@@ -1448,6 +1448,6 @@ class SuiteRequirements(Requirements):
         return exclusions.open()
 
     @property
-    def builtin_generics(self):
-        "If list[int] is a valid syntax. basically py3.9+"
-        return exclusions.only_if(lambda: util.py39)
+    def generic_classes(self):
+        "If X[Y] can be implemented with ``__class_getitem__``. py3.7+"
+        return exclusions.only_if(lambda: util.py37)
index 3cd9e1af4971d829490468b2a333324c8568941a..11e7b9eddab7b7800713e46baa659c8977c2e597 100644 (file)
@@ -4,7 +4,7 @@ from sqlalchemy.testing import requires
 
 
 class TestGenerics(fixtures.TestBase):
-    @requires.builtin_generics
+    @requires.generic_classes
     def test_traversible_is_generic(self):
         col = Column[int]
         assert col is Column