]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
Input: mxs-lradc-ts - use guard notation when acquiring spinlock
authorDmitry Torokhov <dmitry.torokhov@gmail.com>
Fri, 23 Aug 2024 00:12:08 +0000 (17:12 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 25 Mar 2026 14:53:57 +0000 (07:53 -0700)
Guard notation simplifies code and shows critical section more clearly.

Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/mxs-lradc-ts.c

index 9e36fee38d612b1700e727d0ace40a4477bcc800..137ab3b60f2d9f6187b88be3aef826a19d784d21 100644 (file)
@@ -500,15 +500,14 @@ static irqreturn_t mxs_lradc_ts_handle_irq(int irq, void *data)
                LRADC_CTRL1_TOUCH_DETECT_IRQ |
                LRADC_CTRL1_LRADC_IRQ(TOUCHSCREEN_VCHANNEL1) |
                LRADC_CTRL1_LRADC_IRQ(TOUCHSCREEN_VCHANNEL2);
-       unsigned long flags;
 
        if (!(reg & mxs_lradc_irq_mask(lradc)))
                return IRQ_NONE;
 
        if (reg & ts_irq_mask) {
-               spin_lock_irqsave(&ts->lock, flags);
-               mxs_lradc_handle_touch(ts);
-               spin_unlock_irqrestore(&ts->lock, flags);
+               scoped_guard(spinlock_irqsave, &ts->lock) {
+                       mxs_lradc_handle_touch(ts);
+               }
                /* Make sure we don't clear the next conversion's interrupt. */
                clr_irq &= ~(LRADC_CTRL1_LRADC_IRQ(TOUCHSCREEN_VCHANNEL1) |
                                LRADC_CTRL1_LRADC_IRQ(TOUCHSCREEN_VCHANNEL2));