]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libsmbclient: Avoid a call to SMBC_errno() in SMBC_chmod_ctx()
authorVolker Lendecke <vl@samba.org>
Tue, 15 Dec 2020 16:15:21 +0000 (17:15 +0100)
committerJeremy Allison <jra@samba.org>
Fri, 6 Aug 2021 17:22:30 +0000 (17:22 +0000)
Directly use the return value from cli_setatr(), don't go via the cli_state
struct member

Signed-off-by: Volker Lendecke <vl@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
source3/libsmb/libsmb_dir.c

index b7a5c2504e664c8963d990e882af5b22eb0691ad..54902ed773febc68162ef4172728d6d310853770 100644 (file)
@@ -2048,9 +2048,10 @@ SMBC_chmod_ctx(SMBCCTX *context,
        if ((newmode & S_IXGRP) && lp_map_system(-1)) attr |= FILE_ATTRIBUTE_SYSTEM;
        if ((newmode & S_IXOTH) && lp_map_hidden(-1)) attr |= FILE_ATTRIBUTE_HIDDEN;
 
-       if (!NT_STATUS_IS_OK(cli_setatr(targetcli, targetpath, attr, 0))) {
-               errno = SMBC_errno(context, targetcli);
+       status = cli_setatr(targetcli, targetpath, attr, 0);
+       if (!NT_STATUS_IS_OK(status)) {
                TALLOC_FREE(frame);
+               errno = cli_status_to_errno(status);
                return -1;
        }