]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
clk: davinci: remove platform data struct
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Tue, 17 Dec 2024 17:41:54 +0000 (18:41 +0100)
committerStephen Boyd <sboyd@kernel.org>
Tue, 17 Dec 2024 18:53:06 +0000 (10:53 -0800)
There are no board files using struct davinci_pll_platform_data anymore.
The structure itself is currently used to store a single pointer. Let's
remove the struct definition, the header and rework the driver to not
require the syscon regmap to be stored in probe().

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Link: https://lore.kernel.org/r/20241217174154.84441-1-brgl@bgdev.pl
Reviewed-by: David Lechner <david@lechnology.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/davinci/pll.c
include/linux/platform_data/clk-davinci-pll.h [deleted file]

index 5bbbb3a6647785781ec3e2148ab69107087aa9fb..82727b1fc67a94ca078b9394f897f8a752398f55 100644 (file)
@@ -19,7 +19,6 @@
 #include <linux/mfd/syscon.h>
 #include <linux/notifier.h>
 #include <linux/of.h>
-#include <linux/platform_data/clk-davinci-pll.h>
 #include <linux/platform_device.h>
 #include <linux/property.h>
 #include <linux/regmap.h>
@@ -840,27 +839,6 @@ int of_davinci_pll_init(struct device *dev, struct device_node *node,
        return 0;
 }
 
-static struct davinci_pll_platform_data *davinci_pll_get_pdata(struct device *dev)
-{
-       struct davinci_pll_platform_data *pdata = dev_get_platdata(dev);
-
-       /*
-        * Platform data is optional, so allocate a new struct if one was not
-        * provided. For device tree, this will always be the case.
-        */
-       if (!pdata)
-               pdata = devm_kzalloc(dev, sizeof(*pdata), GFP_KERNEL);
-       if (!pdata)
-               return NULL;
-
-       /* for device tree, we need to fill in the struct */
-       if (dev->of_node)
-               pdata->cfgchip =
-                       syscon_regmap_lookup_by_compatible("ti,da830-cfgchip");
-
-       return pdata;
-}
-
 /* needed in early boot for clocksource/clockevent */
 #ifdef CONFIG_ARCH_DAVINCI_DA850
 CLK_OF_DECLARE(da850_pll0, "ti,da850-pll0", of_da850_pll0_init);
@@ -890,8 +868,8 @@ typedef int (*davinci_pll_init)(struct device *dev, void __iomem *base,
 static int davinci_pll_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
-       struct davinci_pll_platform_data *pdata;
        davinci_pll_init pll_init = NULL;
+       struct regmap *cfgchip;
        void __iomem *base;
 
        pll_init = device_get_match_data(dev);
@@ -903,17 +881,13 @@ static int davinci_pll_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
-       pdata = davinci_pll_get_pdata(dev);
-       if (!pdata) {
-               dev_err(dev, "missing platform data\n");
-               return -EINVAL;
-       }
+       cfgchip = syscon_regmap_lookup_by_compatible("ti,da830-cfgchip");
 
        base = devm_platform_ioremap_resource(pdev, 0);
        if (IS_ERR(base))
                return PTR_ERR(base);
 
-       return pll_init(dev, base, pdata->cfgchip);
+       return pll_init(dev, base, cfgchip);
 }
 
 static struct platform_driver davinci_pll_driver = {
diff --git a/include/linux/platform_data/clk-davinci-pll.h b/include/linux/platform_data/clk-davinci-pll.h
deleted file mode 100644 (file)
index e55dab1..0000000
+++ /dev/null
@@ -1,21 +0,0 @@
-// SPDX-License-Identifier: GPL-2.0
-/*
- * PLL clock driver for TI Davinci SoCs
- *
- * Copyright (C) 2018 David Lechner <david@lechnology.com>
- */
-
-#ifndef __LINUX_PLATFORM_DATA_CLK_DAVINCI_PLL_H__
-#define __LINUX_PLATFORM_DATA_CLK_DAVINCI_PLL_H__
-
-#include <linux/regmap.h>
-
-/**
- * davinci_pll_platform_data
- * @cfgchip: CFGCHIP syscon regmap
- */
-struct davinci_pll_platform_data {
-       struct regmap *cfgchip;
-};
-
-#endif /* __LINUX_PLATFORM_DATA_CLK_DAVINCI_PLL_H__ */