]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: rockchip: Fix wifi interrupts flag on Sakura Pi RK3308B
authorKrzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Wed, 17 Dec 2025 09:18:08 +0000 (10:18 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Mon, 22 Dec 2025 12:27:52 +0000 (13:27 +0100)
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.

Correct the interrupt flags, assuming the author of the code wanted same
logical behavior behind the name "ACTIVE_xxx", this is:
  ACTIVE_HIGH  => IRQ_TYPE_LEVEL_HIGH

Fixes: 79f2a1702441 ("arm64: dts: rockchip: add DTs for Sakura Pi RK3308B")
Cc: stable+noautosel@kernel.org # Needs testing, because actual level is just a guess
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Acked-by: Chiyuki Akatsuki <thesnowfield@sakurapi.org>
Link: https://patch.msgid.link/20251217091808.38253-2-krzysztof.kozlowski@oss.qualcomm.com
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3308-sakurapi-rk3308b.dts

index e5e6b800c2d163ba25e3164b6e125df4b26f4ca1..3473db08b9b26ddd22866084f7029f8e99385c9c 100644 (file)
                compatible = "brcm,bcm43455-fmac", "brcm,bcm4329-fmac";
                reg = <1>;
                interrupt-parent = <&gpio0>;
-               interrupts = <RK_PA3 GPIO_ACTIVE_HIGH>;
+               interrupts = <RK_PA3 IRQ_TYPE_LEVEL_HIGH>;
                interrupt-names = "host-wake";
                pinctrl-names = "default";
                pinctrl-0 = <&wifi_host_wake>;