]> git.ipfire.org Git - thirdparty/strongswan.git/commitdiff
unit-tests: Don't assert failures for unreadable settings files as root
authorTobias Brunner <tobias@strongswan.org>
Fri, 16 May 2014 15:43:42 +0000 (17:43 +0200)
committerTobias Brunner <tobias@strongswan.org>
Fri, 16 May 2014 15:50:29 +0000 (17:50 +0200)
The file can still be read by root even if nobody has read privileges.

src/libstrongswan/tests/suites/test_settings.c

index e504b95a1b1765a9d61809bd19eec0e7ffc868c2..97e45fc04e019e3bd9bd10f0d572cef6c8450509 100644 (file)
@@ -675,11 +675,14 @@ START_TEST(test_load_files_section)
        ck_assert(!settings->load_files_section(settings, include1".conf", TRUE, ""));
        verify_include();
 
-       /* unreadable files are too */
-       ck_assert(chunk_write(contents, include1".no", 0444, TRUE));
-       ck_assert(!settings->load_files_section(settings, include1".no", TRUE, ""));
-       unlink(include1".no");
-       verify_include();
+       /* unreadable files are too (only fails when not running as root) */
+       if (getuid() != 0)
+       {
+               ck_assert(chunk_write(contents, include1".no", 0444, TRUE));
+               ck_assert(!settings->load_files_section(settings, include1".no", TRUE, ""));
+               unlink(include1".no");
+               verify_include();
+       }
 
        ck_assert(settings->load_files_section(settings, include2, FALSE, "main"));
        verify_null("main.key1");