bus_connection_get_unix_groups: NULL-check *groups, not groups

groups is never NULL here, but *groups can be NULL on OOM, and that's the
check that was intended.

Coverity ID 265358.

Bug: https://bugs.freedesktop.org/show_bug.cgi?id=103737
Reviewed-by: Simon McVittie <smcv@collabora.com>

diff --git a/bus/connection.c b/bus/connection.c
index bcd4aef452d632c6d441cc34c265d35ec5037e88..35f8e36ef93bb331f45c3b90a8e974c94b6acda6 100644 (file)
--- a/bus/connection.c
+++ b/bus/connection.c
@@ -1064,7 +1064,7 @@ bus_connection_get_unix_groups  (DBusConnection   *connection,
       *n_groups = n;
       *groups = dbus_new (unsigned long, n);
 
-      if (groups == NULL)
+      if (*groups == NULL)
         {
           BUS_SET_OOM (error);
           return FALSE;