PM / Hibernate: Enable usermodehelpers in hibernate() error path

commit 05b4877f6a4f1ba4952d1222213d262bf8c132b7 upstream.

If create_basic_memory_bitmaps() fails, usermodehelpers are not re-enabled
before returning. Fix this. And while at it, reword the goto labels so that
they look more meaningful.

Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

diff --git a/kernel/power/hibernate.c b/kernel/power/hibernate.c
index 6d6d28870335831fa05c80428fefc05e20be3f69..7bef75550068ac3b5e68809c510c2e86ce1960c9 100644 (file)
--- a/kernel/power/hibernate.c
+++ b/kernel/power/hibernate.c
@@ -616,7 +616,7 @@ int hibernate(void)
        /* Allocate memory management structures */
        error = create_basic_memory_bitmaps();
        if (error)
-               goto Exit;
+               goto Enable_umh;
 
        printk(KERN_INFO "PM: Syncing filesystems ... ");
        sys_sync();
@@ -624,7 +624,7 @@ int hibernate(void)
 
        error = freeze_processes();
        if (error)
-               goto Finish;
+               goto Free_bitmaps;
 
        error = hibernation_snapshot(hibernation_mode == HIBERNATION_PLATFORM);
        if (error)
@@ -657,8 +657,9 @@ int hibernate(void)
 
  Thaw:
        thaw_processes();
- Finish:
+ Free_bitmaps:
        free_basic_memory_bitmaps();
+ Enable_umh:
        usermodehelper_enable();
  Exit:
        pm_notifier_call_chain(PM_POST_HIBERNATION);