]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
PCI: mvebu: Use fixed-width interrupt masks to avoid truncation in 64-bit builds
authorRosen Penev <rosenp@gmail.com>
Tue, 26 May 2026 04:40:16 +0000 (21:40 -0700)
committerBjorn Helgaas <bhelgaas@google.com>
Thu, 18 Jun 2026 15:15:16 +0000 (10:15 -0500)
Use u32-typed BIT and GENMASK helpers for PCIe interrupt register
masks.  This keeps inverted masks in the same width as the registers
and avoids truncation warnings on 64-bit compile-test builds.

Fixes below and similar warnings:

  drivers/pci/controller/pci-mvebu.c:316:21: error: implicit conversion from 'unsigned long' to 'u32' (aka 'unsigned int') changes value from 18446744069414584320 to 0 [-Werror,-Wconstant-conversion]
           mvebu_writel(port, ~PCIE_INT_ALL_MASK, PCIE_INT_UNMASK_OFF);

Assisted-by: Codex:GPT-5.5
Signed-off-by: Rosen Penev <rosenp@gmail.com>
Signed-off-by: Manivannan Sadhasivam <mani@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Link: https://patch.msgid.link/20260526044016.1025613-1-rosenp@gmail.com
drivers/pci/controller/pci-mvebu.c

index a72aa57591c04edc9660dc8663fa1c038f8a3d5b..07ed45bab5d0fbecb9db1f3cbfdbdd0da46fd7a6 100644 (file)
@@ -57,9 +57,9 @@
 #define PCIE_CONF_DATA_OFF     0x18fc
 #define PCIE_INT_CAUSE_OFF     0x1900
 #define PCIE_INT_UNMASK_OFF    0x1910
-#define  PCIE_INT_INTX(i)              BIT(24+i)
-#define  PCIE_INT_PM_PME               BIT(28)
-#define  PCIE_INT_ALL_MASK             GENMASK(31, 0)
+#define  PCIE_INT_INTX(i)              BIT_U32(24 + (i))
+#define  PCIE_INT_PM_PME               BIT_U32(28)
+#define  PCIE_INT_ALL_MASK             GENMASK_U32(31, 0)
 #define PCIE_CTRL_OFF          0x1a00
 #define  PCIE_CTRL_X1_MODE             0x0001
 #define  PCIE_CTRL_RC_MODE             BIT(1)