]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
tracing: Drop unneeded assignment to soft_mode
authorJulia Lawall <Julia.Lawall@inria.fr>
Fri, 26 Dec 2025 11:05:31 +0000 (12:05 +0100)
committerSteven Rostedt (Google) <rostedt@goodmis.org>
Wed, 7 Jan 2026 19:52:22 +0000 (14:52 -0500)
soft_mode is not read in the enable case, so drop the assignment.
Drop also the comment text that refers to the assignment and realign
the comment.

Cc: "Paul E . McKenney" <paulmck@kernel.org>
Cc: Gabriele Paoloni <gpaoloni@redhat.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
Link: https://patch.msgid.link/20251226110531.4129794-1-Julia.Lawall@inria.fr
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Steven Rostedt (Google) <rostedt@goodmis.org>
kernel/trace/trace_events.c

index 76067529db61bc51e772680ec820e78e5f09cf20..137b4d9bb116d91e945f8057e2a7a773848319f2 100644 (file)
@@ -826,16 +826,15 @@ static int __ftrace_event_enable_disable(struct trace_event_file *file,
                 * When soft_disable is set and enable is set, we want to
                 * register the tracepoint for the event, but leave the event
                 * as is. That means, if the event was already enabled, we do
-                * nothing (but set soft_mode). If the event is disabled, we
-                * set SOFT_DISABLED before enabling the event tracepoint, so
-                * it still seems to be disabled.
+                * nothing. If the event is disabled, we set SOFT_DISABLED
+                * before enabling the event tracepoint, so it still seems
+                * to be disabled.
                 */
                if (!soft_disable)
                        clear_bit(EVENT_FILE_FL_SOFT_DISABLED_BIT, &file->flags);
                else {
                        if (atomic_inc_return(&file->sm_ref) > 1)
                                break;
-                       soft_mode = true;
                        /* Enable use of trace_buffered_event */
                        trace_buffered_event_enable();
                }