]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: rtw89: fw: propagate error code from rtw89_h2c_tx()
authorPing-Ke Shih <pkshih@realtek.com>
Mon, 17 Feb 2025 06:43:06 +0000 (14:43 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 May 2025 09:13:13 +0000 (11:13 +0200)
[ Upstream commit 56e1acaa0f80620b8e2c3410db35b4b975782b0a ]

The error code should be propagated to callers during downloading firmware
header and body. Remove unnecessary assignment of -1.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20250217064308.43559-4-pkshih@realtek.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/realtek/rtw89/fw.c

index 2f3869c70069679f41e32b383cd4f3efb491dff5..4727eeb55b486b34d0dcc56ee7a978fdda812027 100644 (file)
@@ -1322,7 +1322,6 @@ static int __rtw89_fw_download_hdr(struct rtw89_dev *rtwdev,
        ret = rtw89_h2c_tx(rtwdev, skb, false);
        if (ret) {
                rtw89_err(rtwdev, "failed to send h2c\n");
-               ret = -1;
                goto fail;
        }
 
@@ -1409,7 +1408,6 @@ static int __rtw89_fw_download_main(struct rtw89_dev *rtwdev,
                ret = rtw89_h2c_tx(rtwdev, skb, true);
                if (ret) {
                        rtw89_err(rtwdev, "failed to send h2c\n");
-                       ret = -1;
                        goto fail;
                }