]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: s5p-mfc: Corrected NV12M/NV21M plane-sizes
authorAakarsh Jain <aakarsh.jain@samsung.com>
Wed, 26 Feb 2025 10:22:51 +0000 (15:52 +0530)
committerHans Verkuil <hverkuil@xs4all.nl>
Wed, 5 Mar 2025 16:40:18 +0000 (17:40 +0100)
There is a possibility of getting page fault if the overall
buffer size is not aligned to 256bytes. Since MFC does read
operation only and it won't corrupt the data values even if
it reads the extra bytes.
Corrected luma and chroma plane sizes for V4L2_PIX_FMT_NV12M
and V4L2_PIX_FMT_NV21M pixel format.

Suggested-by: Hans Verkuil <hverkuil@xs4all.nl>
Signed-off-by: Aakarsh Jain <aakarsh.jain@samsung.com>
Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>
Acked-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>
drivers/media/platform/samsung/s5p-mfc/s5p_mfc_opr_v6.c

index 73f7af674c01bdedaef7c5037cd1896cce9fd04c..0c636090d723de0efaff8fef74da9ead9534cca8 100644 (file)
@@ -549,8 +549,9 @@ static void s5p_mfc_enc_calc_src_size_v6(struct s5p_mfc_ctx *ctx)
                case V4L2_PIX_FMT_NV21M:
                        ctx->stride[0] = ALIGN(ctx->img_width, S5P_FIMV_NV12M_HALIGN_V6);
                        ctx->stride[1] = ALIGN(ctx->img_width, S5P_FIMV_NV12M_HALIGN_V6);
-                       ctx->luma_size = ctx->stride[0] * ALIGN(ctx->img_height, 16);
-                       ctx->chroma_size =  ctx->stride[0] * ALIGN(ctx->img_height / 2, 16);
+                       ctx->luma_size = ALIGN(ctx->stride[0] * ALIGN(ctx->img_height, 16), 256);
+                       ctx->chroma_size = ALIGN(ctx->stride[0] * ALIGN(ctx->img_height / 2, 16),
+                                       256);
                        break;
                case V4L2_PIX_FMT_YUV420M:
                case V4L2_PIX_FMT_YVU420M: