Ensure we check for boolean condition when we inspect __exit__()

Fixed issue in testing fixtures which was incompatible with a change
made as of Python 3.6.2 involving context managers.

Change-Id: I0f12aa6cc15cba89153f7e4888ac347e7ce599c7
Fixes: #4034

diff --git a/doc/build/changelog/unreleased_10/4034.rst b/doc/build/changelog/unreleased_10/4034.rst
new file mode 100644 (file)
index 0000000..ac4f229
--- /dev/null
+++ b/doc/build/changelog/unreleased_10/4034.rst
@@ -0,0 +1,7 @@
+.. change::
+    :tags: bug, tests, py3k
+    :tickets: 4034
+    :versions: 1.0.18, 1.1.12, 1.2.0b2
+
+    Fixed issue in testing fixtures which was incompatible with a change
+    made as of Python 3.6.2 involving context managers.
\ No newline at end of file

diff --git a/lib/sqlalchemy/testing/util.py b/lib/sqlalchemy/testing/util.py
index a37637ac02974dd79828cd0d32948a6697e455b4..fe696bcd48e897622b04518ebe6b394f87e9f599 100644 (file)
--- a/lib/sqlalchemy/testing/util.py
+++ b/lib/sqlalchemy/testing/util.py
@@ -161,7 +161,7 @@ def run_as_contextmanager(ctx, fn, *arg, **kw):
     except:
         exc_info = sys.exc_info()
         raise_ = ctx.__exit__(*exc_info)
-        if raise_ is None:
+        if not raise_:
             raise
         else:
             return raise_